-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the JVM Implementation after the name of the Vendor #140
Conversation
I'm not a big fan of breaking consumer again (sorry for the last time) but I also see the advantage of putting the JVM implementation into the name tag. This being said, I think GraalVM releases (e. g. |
Unfortunately I do not see a proper way of dealing with #46 and #57 without introducing a breaking change. And my hope is that people will understand the added value of this one.
Good point, missed that one :( Guess graalvm should be in the excemption list, just as hotspot. So only openj9 needs special treatment at this moment I guess? |
@joschi changed it to only do something for openj9. This makes it fragile in case a new jvm_impl is introduced, but I'm no |
@delgurth tremendous work, thank you! I'll merge it once you've had a chance to resolve conflicts. |
@halcyon thanks. My git says I'm up to date with upstream/master and GitHub says I'm not. Will check what's going wrong in a few hours. |
87fc85c
to
ab06cc0
Compare
…if it's not the hotspot jvm
…he test fails this helps to see what part broke.
ab06cc0
to
af81c35
Compare
…this won't happen in the future
I was messing up git history. Fixed the history now for this pull request. 2 more to go. |
adoptopenjdk-8.0.252+9.1.openj9-0.20.0 no longer exists, it's now adoptopenjdk-openj9-8.0.252+9.1.openj9-0.20.0
In order to fix #46 and #57 I've added the jvm_impl after the vendor.
Unfortunately this will break the names configured previously in .tools-versions if you had selected one of the openj9 JDK's. Not sure how you can do this backwards compatible.