-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add references to additional figures #688
Conversation
AppVeyor build 1.0.2374 for commit 6279ff8 failed. |
AppVeyor build 1.0.2377 for commit 9818f90 failed. |
@agitter, something isn't working with the reference to the static figures in the images folder within content. I tried to follow the formatting we used for the other summary figure, so I'm not quite sure what's going wrong!
Edited: I see it now! Another vision issue :( |
AppVeyor build 1.0.2378 for commit e2cc763 is now complete. Found 9 potential spelling error(s). Preview:content/02.introduction.md:18:secnocontent/02.introduction.md:126:png content/02.introduction.md:126:secno content/20.treatments.md:25:secno content/20.treatments.md:830:png content/20.treatments.md:830:secno content/20.treatments.md:954:LifeCyclePlusDrugs content/20.treatments.md:954:png content/20.treatments.md:954:secno... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding these. I'm going to tweak the therapeutics figure to see if that fixes the build issue.
An upstream bug has been fixed so we may be able to get rid of secno=1
in the figures, but let's not mess with that right now.
AppVeyor build 1.0.2383 for commit 3cabdc1 is now complete. Found 0 potential spelling error(s). Preview:... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The figures appeared correctly in the PDF build.
AppVeyor build 1.0.2394 for commit 1360d20 is now complete. Found 0 potential spelling error(s). Preview:... |
[ci skip] This build is based on 9cd87f9. This commit was created by the following CI build and job: https://github.com/greenelab/covid19-review/commit/9cd87f99307c4edb7f679e3d1293254712548375/checks https://github.com/greenelab/covid19-review/runs/357148963
[ci skip] This build is based on 9cd87f9. This commit was created by the following CI build and job: https://github.com/greenelab/covid19-review/commit/9cd87f99307c4edb7f679e3d1293254712548375/checks https://github.com/greenelab/covid19-review/runs/357148963
Description of the proposed additions or changes
This addresses the concerns in #673 about adding in some of the awesome figures that had not been given a location in the manuscript.
I'm going to mark it as a draft pending merge of #600 because that should fix the last broken figure issue we have.The changes to #600 were approved by the original author so if someone else is able to approve, we can merge.
Related issues
#673
Suggested reviewers (optional)
Checklist