Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add references to additional figures #688

Merged
merged 9 commits into from
Nov 11, 2020
Merged

Conversation

rando2
Copy link
Contributor

@rando2 rando2 commented Nov 10, 2020

Description of the proposed additions or changes

This addresses the concerns in #673 about adding in some of the awesome figures that had not been given a location in the manuscript.
I'm going to mark it as a draft pending merge of #600 because that should fix the last broken figure issue we have.
The changes to #600 were approved by the original author so if someone else is able to approve, we can merge.

Related issues

#673

Suggested reviewers (optional)

Checklist

  • Text is formatted so that each sentence is on its own line.
  • Pre-prints cited in this pull request have a GitHub issue opened so that they can be reviewed.

@rando2 rando2 marked this pull request as draft November 10, 2020 21:43
@rando2 rando2 marked this pull request as ready for review November 10, 2020 22:06
@rando2 rando2 requested a review from agitter November 10, 2020 22:09
@AppVeyorBot
Copy link

AppVeyor build 1.0.2374 for commit 6279ff8 failed.

@AppVeyorBot
Copy link

AppVeyor build 1.0.2377 for commit 9818f90 failed.

@rando2
Copy link
Contributor Author

rando2 commented Nov 10, 2020

@agitter, something isn't working with the reference to the static figures in the images folder within content. I tried to follow the formatting we used for the other summary figure, so I'm not quite sure what's going wrong!

![**Summary of the relationships among topics covered in this review.**](images/N000-overview.png){#fig:overview secno=1}

Edited: I see it now! Another vision issue :(

@AppVeyorBot
Copy link

AppVeyor build 1.0.2378 for commit e2cc763 is now complete.

Found 9 potential spelling error(s). Preview:content/02.introduction.md:18:secno
content/02.introduction.md:126:png
content/02.introduction.md:126:secno
content/20.treatments.md:25:secno
content/20.treatments.md:830:png
content/20.treatments.md:830:secno
content/20.treatments.md:954:LifeCyclePlusDrugs
content/20.treatments.md:954:png
content/20.treatments.md:954:secno...
The rendered manuscript from this build is temporarily available for download at:

Copy link
Collaborator

@agitter agitter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding these. I'm going to tweak the therapeutics figure to see if that fixes the build issue.

An upstream bug has been fixed so we may be able to get rid of secno=1 in the figures, but let's not mess with that right now.

@AppVeyorBot
Copy link

AppVeyor build 1.0.2383 for commit 3cabdc1 is now complete.

Found 0 potential spelling error(s). Preview:...
The rendered manuscript from this build is temporarily available for download at:

Copy link
Collaborator

@agitter agitter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The figures appeared correctly in the PDF build.

@AppVeyorBot
Copy link

AppVeyor build 1.0.2394 for commit 1360d20 is now complete.

Found 0 potential spelling error(s). Preview:...
The rendered manuscript from this build is temporarily available for download at:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants