Implement periodic check to notify access list owners of reviews due soon #51581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Base automatically changed from
yassine/access-list-notification-type
to
master
January 29, 2025 05:47
2e0990c to
0ad0040
Compare
0ad0040 to
d403fd5
Compare
zmb3
reviewed
Jan 29, 2025
e1d4901 to
9aecb23
Compare
zmb3
reviewed
Jan 30, 2025
fspmarshall
approved these changes
Jan 30, 2025
avatus
approved these changes
Jan 30, 2025
ab213d3 to
2a11012
Compare
rudream
added a commit
that referenced
this pull request
Jan 31, 2025
carloscastrojumo
pushed a commit
to carloscastrojumo/teleport
that referenced
this pull request
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
ecounterpart: https://github.com/gravitational/teleport.e/pull/5974This PR adds a periodic check which will look for access lists due for review within certain thresholds (14d, 7d, 3d, 0d, -3d, -7d) and create reminder notifications for those capable of reviewing those access lists.
Duplicate notifications are prevented by the use of unique notification identifiers, ie. a particular access list will never trigger more than one 7d reminder. It is however possible for two access lists to trigger 7d reminder notifications at different times.