remove 30d reminder and add 0d

gravitational · Jan 29, 2025 · 0ad0040 · 0ad0040
1 parent 54899d7
commit 0ad0040
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 9 deletions.
diff --git a/api/types/constants.go b/api/types/constants.go
@@ -1171,9 +1171,6 @@ const (
 	// NotificationAccessRequestPromotedSubKind is the subkind for a notification for a user's access request being promoted to an access list.
 	NotificationAccessRequestPromotedSubKind = "access-request-promoted"
 
-	// NotificationAccessListReviewDue30dSubKind is the subkind for a notification for an access list review due in less than 30 days.
-	NotificationAccessListReviewDue30dSubKind = "access-list-review-due-30d"
-
 	// NotificationAccessListReviewDue14dSubKind is the subkind for a notification for an access list review due in less than 14 days.
 	NotificationAccessListReviewDue14dSubKind = "access-list-review-due-14d"
 
@@ -1183,6 +1180,9 @@ const (
 	// NotificationAccessListReviewDue3dSubKind is the subkind for a notification for an access list review due in less than 3 days.
 	NotificationAccessListReviewDue3dSubKind = "access-list-review-due-3d"
 
+	// NotificationAccessListReviewDue0dSubKind is the subkind for a notification for an access list review due today.
+	NotificationAccessListReviewDue0dSubKind = "access-list-review-due-0d"
+
 	// NotificationAccessListReviewOverdue3dSubKind is the subkind for a notification for an access list review overdue by 3 days.
 	NotificationAccessListReviewOverdue3dSubKind = "access-list-review-overdue-3d"
 
@@ -1191,14 +1191,14 @@ const (
 )
 
 const (
-	// NotificationIdentifierPrefixAccessListDueReminder30d is the prefix for unique notification identifiers for 30d access list review reminders.
-	NotificationIdentifierPrefixAccessListDueReminder30d = "access_list_30d_due_reminder"
 	// NotificationIdentifierPrefixAccessListDueReminder14d is the prefix for unique notification identifiers for 14d access list review reminders.
 	NotificationIdentifierPrefixAccessListDueReminder14d = "access_list_14d_due_reminder"
 	// NotificationIdentifierPrefixAccessListDueReminder7d is the prefix for unique notification identifiers for 7d access list review reminders.
 	NotificationIdentifierPrefixAccessListDueReminder7d = "access_list_7d_due_reminder"
 	// NotificationIdentifierPrefixAccessListDueReminder3d is the prefix for unique notification identifiers for 3d access list review reminders.
 	NotificationIdentifierPrefixAccessListDueReminder3d = "access_list_3d_due_reminder"
+	// NotificationIdentifierPrefixAccessListDueReminder0d is the prefix for unique notification identifiers for 0d (today) access list review reminders.
+	NotificationIdentifierPrefixAccessListDueReminder0d = "access_list_0d_due_reminder"
 	// NotificationIdentifierPrefixAccessListDueReminder30d is the prefix for unique notification identifiers for 3d overdue access list review reminders.
 	NotificationIdentifierPrefixAccessListOverdue3d = "access_list_3d_overdue_reminder"
 	// NotificationIdentifierPrefixAccessListDueReminder30d is the prefix for unique notification identifiers for 7d overdue access list review reminders.

diff --git a/lib/auth/auth.go b/lib/auth/auth.go
@@ -6198,10 +6198,10 @@ func (a *Server) CreateAccessListReminderNotifications(ctx context.Context) {
 		title               string
 		overdue             bool
 	}{
-		{30, types.NotificationIdentifierPrefixAccessListDueReminder30d, types.NotificationAccessListReviewDue30dSubKind, "You have access lists due for review in less than 30 days.", false},
 		{14, types.NotificationIdentifierPrefixAccessListDueReminder14d, types.NotificationAccessListReviewDue14dSubKind, "You have access lists due for review in less than 14 days.", false},
 		{7, types.NotificationIdentifierPrefixAccessListDueReminder7d, types.NotificationAccessListReviewDue7dSubKind, "You have access lists due for review in less than 7 days.", false},
 		{3, types.NotificationIdentifierPrefixAccessListDueReminder3d, types.NotificationAccessListReviewDue3dSubKind, "You have access lists due for review in less than 3 days.", false},
+		{1, types.NotificationIdentifierPrefixAccessListDueReminder0d, types.NotificationAccessListReviewDue0dSubKind, "You have access lists due for review today.", false},
 		{3, types.NotificationIdentifierPrefixAccessListOverdue3d, types.NotificationAccessListReviewOverdue3dSubKind, "You have access lists that are more than 3 days overdue for review.", true},
 		{7, types.NotificationIdentifierPrefixAccessListOverdue7d, types.NotificationAccessListReviewOverdue7dSubKind, "You have access lists that are more than 7 days overdue for review.", true},
 	}

diff --git a/web/packages/teleport/src/Notifications/fixtures.ts b/web/packages/teleport/src/Notifications/fixtures.ts
@@ -117,8 +117,8 @@ export const notifications: Notification[] = [
   },
   {
     id: '8',
-    title: `You have access lists that require your review within 30 days.`,
-    subKind: NotificationSubKind.NotificationAccessListReviewDue30d,
+    title: `You have access lists that require your review today.`,
+    subKind: NotificationSubKind.NotificationAccessListReviewDue0d,
     createdDate: subMinutes(Date.now(), 5), // 5 minutes ago
     clicked: false,
     labels: [],

diff --git a/web/packages/teleport/src/services/notifications/types.ts b/web/packages/teleport/src/services/notifications/types.ts
@@ -101,10 +101,10 @@ export enum NotificationSubKind {
   AccessRequestDenied = 'access-request-denied',
   AccessRequestPromoted = 'access-request-promoted',
 
-  NotificationAccessListReviewDue30d = 'access-list-review-due-30d',
   NotificationAccessListReviewDue14d = 'access-list-review-due-14d',
   NotificationAccessListReviewDue7d = 'access-list-review-due-7d',
   NotificationAccessListReviewDue3d = 'access-list-review-due-3d',
+  NotificationAccessListReviewDue0d = 'access-list-review-due-0d',
   NotificationAccessListReviewOverdue3d = 'access-list-review-overdue-3d',
   NotificationAccessListReviewOverdue7d = 'access-list-review-overdue-7d',
 }