Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Web] Add access list notification type #51426

Merged
merged 2 commits into from
Jan 29, 2025
Merged

[Web] Add access list notification type #51426

merged 2 commits into from
Jan 29, 2025

Conversation

rudream
Copy link
Contributor

@rudream rudream commented Jan 23, 2025 •
edited
Loading

Purpose

e counterpart: https://github.com/gravitational/teleport.e/pull/5922

Adds a new notification type for access list reminder notifications. The logic that creates these notifications will be in a separate PR.

Demo

image

@rudream rudream added no-changelog Indicates that a PR does not require a changelog entry backport/branch/v17 labels Jan 23, 2025
@rudream rudream requested review from avatus and removed request for flyinghermit January 23, 2025 18:29
@rudream rudream force-pushed the yassine/access-list-notification-type branch from 3e92962 to e9bc87e Compare January 23, 2025 20:11
@rudream rudream requested review from kimlisa and avatus January 28, 2025 19:51
@rudream rudream force-pushed the yassine/access-list-notification-type branch from 6bb839f to c734125 Compare January 28, 2025 21:33
@rudream rudream force-pushed the yassine/access-list-notification-type branch from c734125 to a927f5b Compare January 28, 2025 21:33
@rudream rudream enabled auto-merge January 29, 2025 05:07
@rudream rudream added this pull request to the merge queue Jan 29, 2025
Merged via the queue into master with commit c907235 Jan 29, 2025
46 checks passed
@rudream rudream deleted the yassine/access-list-notification-type branch January 29, 2025 05:47
@public-teleport-github-review-bot
Copy link

@rudream See the table below for backport results.

Branch Result
branch/v17 Failed

rudream added a commit that referenced this pull request Jan 31, 2025
@rudream
add access list reminder notification type (#51426)
0490a5e
@rudream rudream mentioned this pull request Jan 31, 2025
Merged
github-merge-queue bot pushed a commit that referenced this pull request Jan 31, 2025
@rudream
[v17] [Web] Implement periodic check to notify access list owners of …
f9907d3 
…reviews due soon (#51713)

* add access list reminder notification type (#51426)

* periodically create access list reminder notifications when needed (#51581)
carloscastrojumo pushed a commit to carloscastrojumo/teleport that referenced this pull request Feb 19, 2025
@rudream @carloscastrojumo
add access list reminder notification type (gravitational#51426)
684afee
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avatus avatus avatus approved these changes

@kimlisa kimlisa kimlisa approved these changes

Assignees
No one assigned
Labels
backport/branch/v17 no-changelog Indicates that a PR does not require a changelog entry size/md ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rudream @avatus @kimlisa