unskip sms verification e2e test #3114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brojd
pushed a commit
that referenced
this pull request
Sep 18, 2024
# What this PR does Since we now have a Mailslurp account we can start running this test. At the moment it is only run 1x daily on a GitHub Actions cron (to avoid incurring costs; [it is skipped](https://github.com/grafana/oncall/blob/dev/.github/workflows/linting-and-tests.yml#L317) via a Playwright "[test annotation filter](https://github.com/grafana/oncall/blob/dev/grafana-plugin/package.json#L14-L15)"). `MAILSLURP_API_KEY` repo secret has already been updated. Closes #2693
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Since we now have a Mailslurp account we can start running this test. At the moment it is only run 1x daily on a GitHub Actions cron (to avoid incurring costs; it is skipped via a Playwright "test annotation filter").
MAILSLURP_API_KEYrepo secret has already been updated.Closes #2693