Skip to content

Commit

Permalink
unskip sms verification e2e test (#3114)
Browse files Browse the repository at this point in the history
# What this PR does

Since we now have a Mailslurp account we can start running this test. At
the moment it is only run 1x daily on a GitHub Actions cron (to avoid
incurring costs; [it is
skipped](https://github.com/grafana/oncall/blob/dev/.github/workflows/linting-and-tests.yml#L317)
via a Playwright "[test annotation
filter](https://github.com/grafana/oncall/blob/dev/grafana-plugin/package.json#L14-L15)").

`MAILSLURP_API_KEY` repo secret has already been updated.

Closes #2693
  • Loading branch information
joeyorlando authored Oct 4, 2023
1 parent 1f9f889 commit b554c77
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions e2e-tests/alerts/sms.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,7 @@ import { createIntegrationAndSendDemoAlert } from '../utils/integrations';
import { waitForSms } from '../utils/phone';
import { configureUserNotificationSettings, verifyUserPhoneNumber } from '../utils/userSettings';

// TODO: enable once we've signed up for a MailSlurp account to receieve SMSes
test.skip('we can verify our phone number + receive an SMS alert @expensive', async ({ adminRolePage }) => {
test('we can verify our phone number + receive an SMS alert @expensive', async ({ adminRolePage }) => {
const { page, userName } = adminRolePage;
const escalationChainName = generateRandomValue();
const integrationName = generateRandomValue();
Expand Down

0 comments on commit b554c77

Please sign in to comment.