Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uncomment out/finish e2e test for SMS verification/alert notification workflow #2693

Closed
joeyorlando opened this issue Jul 31, 2023 · 3 comments · Fixed by #3114
Closed

Uncomment out/finish e2e test for SMS verification/alert notification workflow #2693

joeyorlando opened this issue Jul 31, 2023 · 3 comments · Fixed by #3114
Assignees
@joeyorlando
Labels
feature request New feature or request part:alert flow & configuration

Comments

@joeyorlando
Copy link
Contributor

joeyorlando commented Jul 31, 2023 •
edited
Loading

What would you like to see!

We have (unfortunately) broken this workflow a few times. This results in issues like #2687 as well as customer escalations.

There is already an e2e test which does the following:

  • verifies a phone number for the test user
  • adds SMS notifications to the user's personal notification policy
  • sends a demo alert and asserts that the user receives the SMS

Deliverables

  • re-activate this test. Configure CI to contain the necessary environment variables to be able to successfully run this test. Note: you will also need to add these same environment variables to oncall-private
  • also, we should only run this particular test on commits to dev and/or master. avoid running it on every feature branch commit as Mailslurp has a "pay as you go" model for inbound SMSes. See the Playwright docs on "Tagging tests" for how to get started on conditionally running tests like this.

Product Area

Alert Flow & Configuration

Anything else to add?

No response
@joeyorlando joeyorlando added the feature request New feature or request label Jul 31, 2023
@github-actions
Copy link
Contributor

The current version of Grafana OnCall, at the time this issue was opened, is v1.3.19. If your issue pertains to an older version of Grafana OnCall, please be sure to list it in the PR description. Thank you 😄!

@joeyorlando
Copy link
Contributor Author

Note to whomever takes this issue. There is already a MAILSLURP_API_KEY repository secret. However, it is old and should be overwritten with a new API key once IT finishes setting up the MailSlurp account.

@joeyorlando joeyorlando self-assigned this Aug 3, 2023
@joeyorlando joeyorlando linked a pull request Aug 8, 2023 that will close this issue
fix a few flaky e2e tests + allow running project locally via k8s/helm #2751
Merged
3 tasks
@joeyorlando joeyorlando removed a link to a pull request Aug 18, 2023
fix a few flaky e2e tests + allow running project locally via k8s/helm #2751
Merged
3 tasks
@joeyorlando
Copy link
Contributor Author

got access from procurement, however there now seems to be an issue when upgrading the plan in MailSlurp. I've sent a support request to the MailSlurp team, will move this to blocked until I hear back from them.

@joeyorlando joeyorlando mentioned this issue Oct 4, 2023
Merged
joeyorlando added a commit that referenced this issue Oct 4, 2023
@joeyorlando
unskip sms verification e2e test (#3114)
d6c0150 
# What this PR does

Since we now have a Mailslurp account we can start running this test. At
the moment it is only run 1x daily on a GitHub Actions cron (to avoid
incurring costs; [it is
skipped](https://github.com/grafana/oncall/blob/dev/.github/workflows/linting-and-tests.yml#L317)
via a Playwright "[test annotation
filter](https://github.com/grafana/oncall/blob/dev/grafana-plugin/package.json#L14-L15)").

`MAILSLURP_API_KEY` repo secret has already been updated.

Closes #2693
brojd pushed a commit that referenced this issue Sep 18, 2024
@joeyorlando
unskip sms verification e2e test (#3114)
b554c77 
# What this PR does

Since we now have a Mailslurp account we can start running this test. At
the moment it is only run 1x daily on a GitHub Actions cron (to avoid
incurring costs; [it is
skipped](https://github.com/grafana/oncall/blob/dev/.github/workflows/linting-and-tests.yml#L317)
via a Playwright "[test annotation
filter](https://github.com/grafana/oncall/blob/dev/grafana-plugin/package.json#L14-L15)").

`MAILSLURP_API_KEY` repo secret has already been updated.

Closes #2693
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joeyorlando joeyorlando

Labels
feature request New feature or request part:alert flow & configuration
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

unskip sms verification e2e test grafana/oncall
1 participant
@joeyorlando