-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: support gzip decompression on metadata requests #383
Conversation
Codecov Report
@@ Coverage Diff @@
## main #383 +/- ##
==========================================
+ Coverage 92.25% 92.28% +0.03%
==========================================
Files 51 51
Lines 8202 8235 +33
==========================================
+ Hits 7567 7600 +33
Misses 635 635
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but frankly it is a bit of a rubber stamp. If you need somebody who actually understands what is going on, maybe ask @frankyn?
I'm working with @cojenco, thanks @coryan! This helps resolves most of the issues; I still see failures for HmacKey requests though;
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @cojenco that helped resolve the failures in the Java conf tests. Cheers!
Fixes #379
Adds gzip decompression support using the
before_request
decoratorContent-Encoding: "gzip"
is present in request headerscontentEncoding: "gzip"
in upload requests so that we can store data compressed when applicable and preserve decompressive transcoding improvements made in fix: decompressive transcoding improvements #322