Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support gzip compressed JSON bodies in rest testbench #379

Closed
frankyn opened this issue Jul 18, 2022 · 0 comments · Fixed by #383
Closed

Support gzip compressed JSON bodies in rest testbench #379

frankyn opened this issue Jul 18, 2022 · 0 comments · Fixed by #383
Assignees
@cojenco
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@frankyn
Copy link
Contributor

frankyn commented Jul 18, 2022 •
edited
Loading

In #322, gzip decompression of request bodies was refactored to properly handle media uploads, however the PR removed support for handling gzip compressed JSON bodies for metadata operations. The change broke Java conformance tests in newer versions because the client compresses JSON bodies on request and is not parse-able by the flask app.

We need to add the gzip decompression when Content-Type: gzip is present on metadata requests.
@frankyn frankyn added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Jul 18, 2022
@frankyn frankyn mentioned this issue Jul 18, 2022
Merged
@cojenco cojenco mentioned this issue Jul 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cojenco cojenco

Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: support gzip decompression on metadata requests cojenco/storage-testbench
2 participants
@frankyn @cojenco