Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: decompressive transcoding improvements #322

Merged
merged 1 commit into from
May 2, 2022
Merged

fix: decompressive transcoding improvements #322

merged 1 commit into from
May 2, 2022

Conversation

coryan
Copy link
Contributor

@coryan coryan commented May 1, 2022

Store the data in compressed form (if applicable), I believe this is a
better approach as it:

  • Makes the size and checksum attributes match the behavior in the
    service.
  • It enables support for Accept-Encoding, we can return compressed
    data.
  • It makes the gRPC case match the service behavior, i.e., always return
    compressed data.

Fixes #321

Store the data in compressed form (if applicable), I believe this is a
better approach as it:

- Makes the `size` and checksum attributes match the behavior in the
  service.
- It enables support for `Accept-Encoding`, we can return compressed
  data.
- It makes the gRPC case match the service behavior, i.e., always return
  compressed data.
@codecov
Copy link

codecov bot commented May 1, 2022

Codecov Report

Merging #322 (d3844e1) into main (465f85e) will increase coverage by 0.07%.
The diff coverage is 99.27%.

@@            Coverage Diff             @@
##             main     #322      +/-   ##
==========================================
+ Coverage   92.23%   92.30%   +0.07%     
==========================================
  Files          48       47       -1     
  Lines        7627     7724      +97     
==========================================
+ Hits         7035     7130      +95     
- Misses        592      594       +2     
Flag Coverage Δ
unittests 92.30% <99.27%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
testbench/__init__.py 100.00% <ø> (ø)
tests/test_testbench_object_gzip.py 99.00% <99.00%> (ø)
gcs/object.py 98.11% <100.00%> (-0.57%) ⬇️
testbench/common.py 98.67% <100.00%> (+<0.01%) ⬆️
testbench/rest_server.py 98.67% <100.00%> (+<0.01%) ⬆️
tests/format_multipart_upload.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 465f85e...d3844e1. Read the comment docs.

@coryan coryan marked this pull request as ready for review May 1, 2022 16:35
@coryan coryan requested a review from a team as a code owner May 1, 2022 16:35
Copy link
Contributor

@tritone tritone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice improvement, thank you!

@coryan coryan merged commit a81509a into googleapis:main May 2, 2022
@coryan coryan deleted the feat-decompressive-transcoding branch May 2, 2022 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Review implementation of decompressive transcoding
2 participants