feat!: Infer default resource in logger #315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
* added code to remove extra topics in snippet tests * fixed lint issue
Post-Processor: gcr.io/repo-automation-bots/owlbot-python:latest@sha256:58c7342b0bccf85028100adaa3d856cb4a871c22ca9c01960d996e66c40548ce
simonz130
approved these changes
Jun 17, 2021
| labels (Optional[dict]): Mapping of default labels for entries written | ||
| via this logger. | ||
|
|
||
| """ | ||
| if not resource: | ||
| # infer the correct monitored resource from the local environment | ||
| resource = detect_resource(client.project) |
There was a problem hiding this comment.
will this default to "global" in case the environment wasn't detected? (i.e. the code is running in dataflow job)
There was a problem hiding this comment.
Yes, global is the fallback for detect_resource
daniel-sanche
added a commit
that referenced
this pull request
Jan 27, 2022
daniel-sanche
added a commit
that referenced
this pull request
Jan 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recently added functionality to the library to detect the monitored resource type based on the environment the code is running in (#200, #207). Starting with v3.0.0, this detected data should be populated by default by default when sending new logs, rather than defaulting to
global.This behaviour is already in place when using the logging handlers with the logging stdlib. Now calling the library methods directly will behave consistently
Fixes #239