Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change default resource #239

Closed
daniel-sanche opened this issue Mar 24, 2021 · 1 comment · Fixed by #315
Closed

change default resource #239

daniel-sanche opened this issue Mar 24, 2021 · 1 comment · Fixed by #315
Assignees
@daniel-sanche
Labels
api: logging Issues related to the googleapis/python-logging API. priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Milestone
v3.0.0 Breaking

Comments

@daniel-sanche
Copy link
Contributor

Revert #237 at next breaking release
@product-auto-label product-auto-label bot added the api: logging Issues related to the googleapis/python-logging API. label Mar 24, 2021
@daniel-sanche daniel-sanche added this to the v3.0.0 Breaking milestone Mar 24, 2021
@daniel-sanche daniel-sanche self-assigned this Mar 24, 2021
@daniel-sanche daniel-sanche added priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels Mar 24, 2021
@daniel-sanche
Copy link
Contributor Author

daniel-sanche commented Mar 24, 2021 •
edited
Loading

Also, users should be able to set logger resource type when creating a client:

client = google.cloud.logging.Client(project='test-project')
logger = client.logger('test-log', resource=my-resource)
logger.log_struct(dict(foo='bar'))

Support kwargs in client.logger

@daniel-sanche daniel-sanche mentioned this issue Jun 4, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@daniel-sanche daniel-sanche

Labels
api: logging Issues related to the googleapis/python-logging API. priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
v3.0.0 Breaking
Development

Successfully merging a pull request may close this issue.

feat!: Infer default resource in logger googleapis/python-logging
1 participant
@daniel-sanche