test: clean up extra topics from snippet tests #324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonz130
approved these changes
Jun 15, 2021
| # create callback wrapper to delete topic when done | ||
| class TopicDeleter: | ||
| def delete(self): | ||
| client.delete_topic(request={"topic": topic_path}) |
There was a problem hiding this comment.
nit: perhaps, worth adding a log line that topic X is deleted - for easier troubleshooting if tests fail in the future
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ths PR removes topics created in the snippet test project that weren't being properly cleaned up
Fixes: #323