-
Notifications
You must be signed in to change notification settings - Fork 430
Conversation
$ git log -1 --pretty=%H # What is HEAD at time of doing "log"
6e3c0c58f5a3ba18dc69bce9c49a975738c46c74
$ git log v1.4.12..HEAD \
> | grep 'Merge pull request ' \
> | awk -F ' ' '{print $4}' \
> | sort yields #203 |
OK I synthesized all the PRs into short snippets. I've gotta commute now, can someone (@nathanielmanistaatgoogle probably) fix these up into something readable and then I'll put them in the CHANGELOG? #203 - Fix (more like clarify) bytes/string handling in crypto methods. |
@nathanielmanistaatgoogle I'm looking for your guidance on which UPDATE: FWIW the ones I think are worth keeping around are #203 - Fix (more like clarify) bytes/string handling in crypto methods. |
I'm happy to do it but I'm not going to get to this until Saturday afternoon at the earliest. Does that make too much trouble? |
Not for me. @jonparrott Is timing an issue for you? |
Sometime in the next two weeks works for me. On Thu, Aug 27, 2015, 1:20 PM Danny Hermes notifications@github.com wrote:
|
@nathanielmanistaatgoogle do you have some time to go through and decide which "Admin" PRs are worth mentioning in a release and which are not? Updating at 19abb4d #290 - Admin (100% coverage: crypt) |
I intend to find time for this later this afternoon or sometime tomorrow - thank you for your patience. :-) |
#219 and #222 get one line in the release notes as they represent one logical semantic change to the library. #237, #238, and #244 get one line as they too are fellow-travelers. Don't include any of the admin changes (#265, #267, #276, #287, or any of the others). I'm enormously grateful for the improvements but release notes are for users of the library. Documentation improvements are expected to be happening all the time and don't require any consequent changes to the code of applications using the library and the library's tests are out of the picture entirely (how silly would it be to require users to run the test suite before writing code depending on oauth2client?). Thank you for the release and for your patience awaiting my comments. :-) |
fd9b11a
to
fb127ab
Compare
fb127ab
to
4bb4c4a
Compare
@nathanielmanistaatgoogle PTAL. I updated You can view it rendered at: On the release the |
Side question: Shall we use The current tags are $ git tag
v1.3
v1.3.1
v1.3.2
v1.4
v1.4.1
v1.4.10
v1.4.11
v1.4.12
v1.4.2
v1.4.3
v1.4.4
v1.4.5
v1.4.6
v1.4.7
v1.4.8
v1.4.9 Notice that https://readthedocs.org/projects/oauth2client/versions/ has all the |
"v" is fine; it's consistent with what the codebase has done to this point and I don't think it's going to scare anyone off. Looks good; ship it. :-) |
After the build for this merge (https://travis-ci.org/google/oauth2client/builds/78612931) finishes, I'll push the tag and then (fingers crossed) Travis will push to PyPI. |
OK. Tag pushed and building: |
w00t New version pushed: https://pypi.python.org/pypi/oauth2client/1.5.0 |
Bravo! Thanks everyone. |
/cc @nathanielmanistaatgoogle @jonparrott @craigcitro
(Working out changelog still, will update PR once done)