Skip to content
This repository has been archived by the owner on Jan 18, 2025. It is now read-only.

Pinning mock at version 1.0.1. #221

Merged
merged 1 commit into from
Jul 10, 2015
Merged

Conversation

dhermes
Copy link
Contributor

@dhermes dhermes commented Jul 10, 2015

Upgrading to both 1.1.0 and 1.1.1 causes unexplained failures that need to be investigated. This is a stop-gap measure to keep the tests passing and the changelog of mock will need to be inspected.

See https://travis-ci.org/google/oauth2client/builds/70413246 for an example failure (from #220).

Upgrading to both 1.1.0 and 1.1.1 causes unexplained failures
that need to be investigated. This is a stop-gap measure
to keep the tests passing and the changelog of `mock` will
need to be inspected.

See https://travis-ci.org/google/oauth2client/builds/70413246 for
an example failure.
@dhermes
Copy link
Contributor Author

dhermes commented Jul 10, 2015

@nathanielmanistaatgoogle @anthmgoogle I am going to merge this once Travis passes so that other contributions won't fail for reasons unrelated to their code.

dhermes added a commit that referenced this pull request Jul 10, 2015
@dhermes dhermes merged commit ea9b8c4 into googleapis:master Jul 10, 2015
@dhermes dhermes deleted the fix-mock-failure branch July 10, 2015 17:52
@nathanielmanistaatgoogle
Copy link
Contributor

LGTM; thanks for pursuing this.

@dhermes dhermes mentioned this pull request Aug 26, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants