This repository has been archived by the owner on Nov 5, 2019. It is now read-only.
Getting to 100% coverage for clientsecrets module. #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if client_type not in VALID_CLIENT: | ||
| raise InvalidClientSecretsError( | ||
| 'Unknown client type: %s.' % (client_type,)) | ||
| client_info = obj[client_type] |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
Looks good to me; consider my one comment optional and merge at your leisure. |
1c46582 to
684f542
Compare
|
I did as you asked and also dealt with the possibility that the input was not a dictionary. |
dhermes
added a commit
that referenced
this pull request
Aug 24, 2015
Getting to 100% coverage for clientsecrets module.
|
I like it; nice use of unpacking. |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.