Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid overwriting '__module__' of messages from shared modules. #5364

Merged
merged 1 commit into from
May 22, 2018
Merged

Avoid overwriting '__module__' of messages from shared modules. #5364

merged 1 commit into from
May 22, 2018

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented May 22, 2018

Note that we are still overwriting it for messages from modules defined within the current package.

See #4715.

@tseaver
Avoid overwriting '__module__' of messages from shared modules.
24e29a1 
Note that we *are* still overwriting it for messages from modules defined
within the current package.

See #4715.
@tseaver tseaver added api: datastore Issues related to the Datastore API. api: pubsub Issues related to the Pub/Sub API. api: bigtable Issues related to the Bigtable API. api: logging Issues related to the Cloud Logging API. api: vision Issues related to the Cloud Vision API. api: monitoring Issues related to the Cloud Monitoring API. api: speech Issues related to the Speech-to-Text API. api: spanner Issues related to the Spanner API. api: clouderrorreporting Issues related to the Error Reporting API. api: language Issues related to the Cloud Natural Language API API. api: cloudtrace Issues related to the Cloud Trace API. api: videointelligence Issues related to the Video Intelligence API API. api: firestore Issues related to the Firestore API. api: dataproc Issues related to the Dataproc API. api: container Issues related to the Kubernetes Engine API API. api: bigquerydatatransfer Issues related to the BigQuery Data Transfer Service API. api: dlp Issues related to the Sensitive Data Protection API. api: texttospeech Issues related to the Text-to-Speech API. api: redis Issues related to the Memorystore for Redis API. labels May 22, 2018
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 22, 2018
@theacodes
Copy link
Contributor

@crwilcox @lukesneeringer can either of you see about moving this into the generator?

@tseaver tseaver merged commit e592ca3 into googleapis:master May 22, 2018
@tseaver tseaver deleted the 4715-drop_mutating_external_message_module branch May 22, 2018 20:03
This was referenced Jun 11, 2018
Merged
Merged
@tseaver tseaver mentioned this pull request Jun 11, 2018
Merged
@crwilcox crwilcox mentioned this pull request Jun 11, 2018
Closed
@tseaver tseaver mentioned this pull request Aug 28, 2018
Closed
@tseaver tseaver mentioned this pull request Jun 7, 2018
Open
atulep pushed a commit that referenced this pull request Apr 3, 2023
@tseaver
Avoid overwriting '__module__' of messages from shared modules. (#5364)
d7f0c5f 
Note that we *are* still overwriting it for messages from modules defined
within the current package.

See #4715.
atulep pushed a commit that referenced this pull request Apr 18, 2023
@tseaver
Avoid overwriting '__module__' of messages from shared modules. (#5364)
87237c6 
Note that we *are* still overwriting it for messages from modules defined
within the current package.

See #4715.
parthea pushed a commit that referenced this pull request Jun 4, 2023
@tseaver
Avoid overwriting '__module__' of messages from shared modules. (#5364)
dd06697 
Note that we *are* still overwriting it for messages from modules defined
within the current package.

See #4715.
parthea pushed a commit that referenced this pull request Jun 4, 2023
@tseaver
Avoid overwriting '__module__' of messages from shared modules. (#5364)
15f3d24 
Note that we *are* still overwriting it for messages from modules defined
within the current package.

See #4715.
parthea pushed a commit that referenced this pull request Jul 6, 2023
@tseaver
Avoid overwriting '__module__' of messages from shared modules. (#5364)
e630dd5 
Note that we *are* still overwriting it for messages from modules defined
within the current package.

See #4715.
parthea pushed a commit that referenced this pull request Sep 22, 2023
@tseaver
Avoid overwriting '__module__' of messages from shared modules. (#5364)
5041b53 
Note that we *are* still overwriting it for messages from modules defined
within the current package.

See #4715.
parthea pushed a commit that referenced this pull request Sep 22, 2023
@tseaver
Avoid overwriting '__module__' of messages from shared modules. (#5364)
d40d733 
Note that we *are* still overwriting it for messages from modules defined
within the current package.

See #4715.
parthea pushed a commit that referenced this pull request Sep 22, 2023
@tseaver
Avoid overwriting '__module__' of messages from shared modules. (#5364)
f16a487 
Note that we *are* still overwriting it for messages from modules defined
within the current package.

See #4715.
parthea pushed a commit that referenced this pull request Sep 22, 2023
@tseaver
Avoid overwriting '__module__' of messages from shared modules. (#5364)
df86806 
Note that we *are* still overwriting it for messages from modules defined
within the current package.

See #4715.
parthea pushed a commit that referenced this pull request Sep 22, 2023
@tseaver
Avoid overwriting '__module__' of messages from shared modules. (#5364)
8371b09 
Note that we *are* still overwriting it for messages from modules defined
within the current package.

See #4715.
parthea pushed a commit that referenced this pull request Sep 22, 2023
@tseaver
Avoid overwriting '__module__' of messages from shared modules. (#5364)
980187b 
Note that we *are* still overwriting it for messages from modules defined
within the current package.

See #4715.
parthea pushed a commit that referenced this pull request Sep 22, 2023
@tseaver
Avoid overwriting '__module__' of messages from shared modules. (#5364)
9072c7f 
Note that we *are* still overwriting it for messages from modules defined
within the current package.

See #4715.
parthea pushed a commit that referenced this pull request Oct 21, 2023
@tseaver
Avoid overwriting '__module__' of messages from shared modules. (#5364)
924efae 
Note that we *are* still overwriting it for messages from modules defined
within the current package.

See #4715.
parthea pushed a commit that referenced this pull request Oct 21, 2023
@tseaver
Avoid overwriting '__module__' of messages from shared modules. (#5364)
53090a8 
Note that we *are* still overwriting it for messages from modules defined
within the current package.

See #4715.
parthea pushed a commit that referenced this pull request Oct 22, 2023
@tseaver
Avoid overwriting '__module__' of messages from shared modules. (#5364)
98a4c08 
Note that we *are* still overwriting it for messages from modules defined
within the current package.

See #4715.
parthea pushed a commit that referenced this pull request Oct 22, 2023
@tseaver
Avoid overwriting '__module__' of messages from shared modules. (#5364)
a9b2cc5 
Note that we *are* still overwriting it for messages from modules defined
within the current package.

See #4715.
parthea pushed a commit that referenced this pull request Oct 31, 2023
@tseaver
Avoid overwriting '__module__' of messages from shared modules. (#5364)
b709e77 
Note that we *are* still overwriting it for messages from modules defined
within the current package.

See #4715.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theacodes theacodes theacodes approved these changes

@lukesneeringer lukesneeringer Awaiting requested review from lukesneeringer

@crwilcox crwilcox Awaiting requested review from crwilcox

Assignees
No one assigned
Labels
api: bigquerydatatransfer Issues related to the BigQuery Data Transfer Service API. api: bigtable Issues related to the Bigtable API. api: clouderrorreporting Issues related to the Error Reporting API. api: cloudtrace Issues related to the Cloud Trace API. api: container Issues related to the Kubernetes Engine API API. api: dataproc Issues related to the Dataproc API. api: datastore Issues related to the Datastore API. api: dlp Issues related to the Sensitive Data Protection API. api: firestore Issues related to the Firestore API. api: language Issues related to the Cloud Natural Language API API. api: logging Issues related to the Cloud Logging API. api: monitoring Issues related to the Cloud Monitoring API. api: pubsub Issues related to the Pub/Sub API. api: redis Issues related to the Memorystore for Redis API. api: spanner Issues related to the Spanner API. api: speech Issues related to the Speech-to-Text API. api: texttospeech Issues related to the Text-to-Speech API. api: videointelligence Issues related to the Video Intelligence API API. api: vision Issues related to the Cloud Vision API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tseaver @theacodes @googlebot