Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regenerate vision gapics #5467

Merged
merged 1 commit into from
Jun 11, 2018
Merged

Regenerate vision gapics #5467

merged 1 commit into from
Jun 11, 2018

Conversation

theacodes
Copy link
Contributor

No description provided.

@theacodes theacodes requested a review from crwilcox June 11, 2018 19:36
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 11, 2018
tseaver
tseaver suggested changes Jun 11, 2018
View reviewed changes
vision/google/cloud/vision_v1/types.py
status_pb2,
color_pb2,
latlng_pb2,
):

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

crwilcox
crwilcox approved these changes Jun 11, 2018
View reviewed changes
Copy link
Contributor

@crwilcox crwilcox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

versions are backwards (v1 should be last so it overrides the betas for top-level files/docs)

@theacodes theacodes merged commit 74ff4cc into master Jun 11, 2018
@theacodes theacodes deleted the vision-regenerate branch June 11, 2018 22:54
@tseaver
Copy link
Contributor

tseaver commented Jun 12, 2018

@theacodes Did you overlook my comment on undoing #5364?

@tseaver tseaver mentioned this pull request Jun 12, 2018
Closed
@tseaver tseaver added the api: vision Issues related to the Cloud Vision API. label Jun 12, 2018
@theacodes
Copy link
Contributor Author

@tseaver saw it, but we won't be fixing it here. We'll wait for the generator fix and re-generate.

parthea pushed a commit that referenced this pull request Oct 21, 2023
@theacodes
Regenerate underlying client library (#5467)
99e9b4c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tseaver tseaver tseaver requested changes

@crwilcox crwilcox crwilcox approved these changes

@lukesneeringer lukesneeringer Awaiting requested review from lukesneeringer

Assignees
No one assigned
Labels
api: vision Issues related to the Cloud Vision API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@theacodes @tseaver @crwilcox @googlebot