Skip to content

Commit

Permalink
Avoid overwriting '__module__' of messages from shared modules. (#5364)
Browse files Browse the repository at this point in the history
Note that we *are* still overwriting it for messages from modules defined
within the current package.

See #4715.
  • Loading branch information
tseaver authored May 22, 2018
1 parent 8e6a031 commit 9072c7f
Show file tree
Hide file tree
Showing 4 changed files with 104 additions and 55 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,7 @@
from __future__ import absolute_import
import sys

from google.api_core.protobuf_helpers import get_messages

from google.api import http_pb2
from google.cloud.videointelligence_v1.proto import video_intelligence_pb2
from google.longrunning import operations_pb2
from google.protobuf import any_pb2
from google.protobuf import descriptor_pb2
Expand All @@ -27,18 +24,33 @@
from google.protobuf import timestamp_pb2
from google.rpc import status_pb2

from google.api_core.protobuf_helpers import get_messages
from google.cloud.videointelligence_v1.proto import video_intelligence_pb2


_shared_modules = [
http_pb2,
operations_pb2,
any_pb2,
descriptor_pb2,
duration_pb2,
empty_pb2,
timestamp_pb2,
status_pb2,
]

_local_modules = [
video_intelligence_pb2,
]

names = []
for module in (
http_pb2,
video_intelligence_pb2,
operations_pb2,
any_pb2,
descriptor_pb2,
duration_pb2,
empty_pb2,
timestamp_pb2,
status_pb2,
):

for module in _shared_modules:
for name, message in get_messages(module).items():
setattr(sys.modules[__name__], name, message)
names.append(name)

for module in _local_modules:
for name, message in get_messages(module).items():
message.__module__ = 'google.cloud.videointelligence_v1.types'
setattr(sys.modules[__name__], name, message)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,28 +15,40 @@
from __future__ import absolute_import
import sys

from google.api_core.protobuf_helpers import get_messages

from google.api import http_pb2
from google.cloud.videointelligence_v1beta1.proto import video_intelligence_pb2
from google.longrunning import operations_pb2
from google.protobuf import any_pb2
from google.protobuf import descriptor_pb2
from google.protobuf import empty_pb2
from google.protobuf import timestamp_pb2
from google.rpc import status_pb2

from google.api_core.protobuf_helpers import get_messages
from google.cloud.videointelligence_v1beta1.proto import video_intelligence_pb2


_shared_modules = [
http_pb2,
operations_pb2,
any_pb2,
descriptor_pb2,
empty_pb2,
timestamp_pb2,
status_pb2,
]

_local_modules = [
video_intelligence_pb2,
]

names = []
for module in (
http_pb2,
video_intelligence_pb2,
operations_pb2,
any_pb2,
descriptor_pb2,
empty_pb2,
timestamp_pb2,
status_pb2,
):

for module in _shared_modules:
for name, message in get_messages(module).items():
setattr(sys.modules[__name__], name, message)
names.append(name)

for module in _local_modules:
for name, message in get_messages(module).items():
message.__module__ = 'google.cloud.videointelligence_v1beta1.types'
setattr(sys.modules[__name__], name, message)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,7 @@
from __future__ import absolute_import
import sys

from google.api_core.protobuf_helpers import get_messages

from google.api import http_pb2
from google.cloud.videointelligence_v1beta2.proto import video_intelligence_pb2
from google.longrunning import operations_pb2
from google.protobuf import any_pb2
from google.protobuf import descriptor_pb2
Expand All @@ -27,18 +24,33 @@
from google.protobuf import timestamp_pb2
from google.rpc import status_pb2

from google.api_core.protobuf_helpers import get_messages
from google.cloud.videointelligence_v1beta2.proto import video_intelligence_pb2


_shared_modules = [
http_pb2,
operations_pb2,
any_pb2,
descriptor_pb2,
duration_pb2,
empty_pb2,
timestamp_pb2,
status_pb2,
]

_local_modules = [
video_intelligence_pb2,
]

names = []
for module in (
http_pb2,
video_intelligence_pb2,
operations_pb2,
any_pb2,
descriptor_pb2,
duration_pb2,
empty_pb2,
timestamp_pb2,
status_pb2,
):

for module in _shared_modules:
for name, message in get_messages(module).items():
setattr(sys.modules[__name__], name, message)
names.append(name)

for module in _local_modules:
for name, message in get_messages(module).items():
message.__module__ = 'google.cloud.videointelligence_v1beta2.types'
setattr(sys.modules[__name__], name, message)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,7 @@
from __future__ import absolute_import
import sys

from google.api_core.protobuf_helpers import get_messages

from google.api import http_pb2
from google.cloud.videointelligence_v1p1beta1.proto import video_intelligence_pb2
from google.longrunning import operations_pb2
from google.protobuf import any_pb2
from google.protobuf import descriptor_pb2
Expand All @@ -27,18 +24,34 @@
from google.protobuf import timestamp_pb2
from google.rpc import status_pb2

from google.api_core.protobuf_helpers import get_messages
from google.cloud.videointelligence_v1p1beta1.proto import (
video_intelligence_pb2)


_shared_modules = [
http_pb2,
operations_pb2,
any_pb2,
descriptor_pb2,
duration_pb2,
empty_pb2,
timestamp_pb2,
status_pb2,
]

_local_modules = [
video_intelligence_pb2,
]

names = []
for module in (
http_pb2,
video_intelligence_pb2,
operations_pb2,
any_pb2,
descriptor_pb2,
duration_pb2,
empty_pb2,
timestamp_pb2,
status_pb2,
):

for module in _shared_modules:
for name, message in get_messages(module).items():
setattr(sys.modules[__name__], name, message)
names.append(name)

for module in _local_modules:
for name, message in get_messages(module).items():
message.__module__ = 'google.cloud.videointelligence_v1p1beta1.types'
setattr(sys.modules[__name__], name, message)
Expand Down

0 comments on commit 9072c7f

Please sign in to comment.