Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add failed dialog to UampPlaylistsScreen #490

Merged
merged 1 commit into from
Aug 15, 2022

Conversation

luizgrp
Copy link
Member

@luizgrp luizgrp commented Aug 15, 2022

WHAT

Add failed dialog to UampPlaylistsScreen.

Screenshot_20220815_104238

WHY

In order to have design closer to Figma specs.
In order to have user journey aligned with Figma specs.

HOW

  • Change ViewModel to emit a "failed" state for any exception;
  • Change screen to display a dialog on Failed state;
  • Add onErrorDialogCancelClick param to screen so it can navigate back when the dialog is dismissed;

Checklist 📋

  • [N/A] Add explicit visibility modifier and explicit return types for public declarations
  • Run spotless check
  • Run tests
  • [N/A] Update metalava's signature text files

@luizgrp luizgrp merged commit 6ad0790 into google:main Aug 15, 2022
@luizgrp luizgrp deleted the mediaui_playlistsscreen_failed_state branch August 15, 2022 10:57
@luizgrp luizgrp requested a review from yschimke August 22, 2022 10:49
Copy link
Collaborator

@yschimke yschimke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luizgrp luizgrp mentioned this pull request Aug 22, 2022
4 tasks
@luizgrp luizgrp self-assigned this Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants