Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display failed dialog if no playlists are available #551

Merged
merged 1 commit into from
Sep 2, 2022
Merged

Display failed dialog if no playlists are available #551

merged 1 commit into from
Sep 2, 2022

Conversation

luizgrp
Copy link
Member

@luizgrp luizgrp commented Sep 2, 2022

WHAT

Display failed dialog if no playlists are available.

Same dialog as implemented in #490 - no retry functionality implemented yet.

WHY

In order to align with Figma specs.

HOW

Emit failed state if data returned from repository is empty.

Checklist 📋

  • [N/A] Add explicit visibility modifier and explicit return types for public declarations
  • Run spotless check
  • Run tests
  • [N/A] Update metalava's signature text files

yschimke
yschimke approved these changes Sep 2, 2022
View reviewed changes
Copy link
Collaborator

@yschimke yschimke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and simple

@luizgrp luizgrp merged commit 2569f39 into google:main Sep 2, 2022
@luizgrp luizgrp deleted the media_sample_playlists_empty branch September 2, 2022 16:12
@luizgrp luizgrp self-assigned this Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yschimke yschimke yschimke approved these changes

Assignees

@luizgrp luizgrp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@luizgrp @yschimke