Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add failed state to Entity screen #510

Merged
merged 1 commit into from
Aug 23, 2022

Conversation

luizgrp
Copy link
Member

@luizgrp luizgrp commented Aug 22, 2022

WHAT

Add failed state to EntityScreen.

Screenshot_20220822_175048

Also fix layout of dialog of UampPlaylistsScreen, as the button wasn't centred as per preview in #490.

Screenshot_20220822_175409

WHY

In order to have design closer to Figma specs.
In order to have user journey aligned with Figma specs.

HOW

  • Change ViewModel to emit a "failed" state for any exception;
  • Change screen to display a dialog on Failed state;
  • Add onErrorDialogCancelClick param to screen so it can navigate back when the dialog is dismissed;

Checklist 📋

  • Add explicit visibility modifier and explicit return types for public declarations
  • Run spotless check
  • Run tests
  • Update metalava's signature text files

@luizgrp luizgrp force-pushed the mediaui_entityscreen_failedstate branch from 53513c0 to 957e606 Compare August 22, 2022 16:55
@luizgrp luizgrp mentioned this pull request Aug 22, 2022
4 tasks
@luizgrp luizgrp marked this pull request as ready for review August 22, 2022 17:54
@luizgrp luizgrp requested a review from yschimke August 23, 2022 07:33
@luizgrp luizgrp merged commit 9e22509 into google:main Aug 23, 2022
@luizgrp luizgrp deleted the mediaui_entityscreen_failedstate branch August 23, 2022 07:36
@luizgrp luizgrp self-assigned this Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants