Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix GraphEdit port connection when graph is zoomed/unzoomed #46441

Merged
merged 1 commit into from
Feb 28, 2021
Merged

Fix GraphEdit port connection when graph is zoomed/unzoomed #46441

merged 1 commit into from
Feb 28, 2021

Conversation

Chaosus
Copy link
Member

@Chaosus Chaosus commented Feb 26, 2021

test

Fix #46425

@Chaosus Chaosus requested a review from a team as a code owner February 26, 2021 07:41
@Chaosus Chaosus added this to the 4.0 milestone Feb 26, 2021
@Chaosus Chaosus changed the title Fix GraphEdit connects when graph is zoomed/unzoomed [WIP] Fix GraphEdit connects when graph is zoomed/unzoomed Feb 26, 2021
@Chaosus Chaosus force-pushed the fix_graphedit_zoom_connection branch from 4ff3ac5 to c544e1b Compare February 26, 2021 08:03
@Chaosus Chaosus changed the title [WIP] Fix GraphEdit connects when graph is zoomed/unzoomed Fix GraphEdit connects when graph is zoomed/unzoomed Feb 26, 2021
@Chaosus Chaosus force-pushed the fix_graphedit_zoom_connection branch from c544e1b to 473524d Compare February 26, 2021 08:10
@Chaosus Chaosus changed the title Fix GraphEdit connects when graph is zoomed/unzoomed [WIP] Fix GraphEdit connects when graph is zoomed/unzoomed Feb 26, 2021
@Chaosus Chaosus force-pushed the fix_graphedit_zoom_connection branch from 473524d to 89e4c66 Compare February 26, 2021 09:18
@Chaosus Chaosus changed the title [WIP] Fix GraphEdit connects when graph is zoomed/unzoomed Fix GraphEdit port connection when graph is zoomed/unzoomed Feb 26, 2021
@Chaosus Chaosus force-pushed the fix_graphedit_zoom_connection branch from 89e4c66 to db82ee9 Compare February 26, 2021 09:23
KoBeWi
KoBeWi reviewed Feb 27, 2021
View reviewed changes
scene/gui/graph_edit.cpp Outdated Show resolved Hide resolved
@Chaosus Chaosus force-pushed the fix_graphedit_zoom_connection branch from db82ee9 to e3131ad Compare February 27, 2021 17:26
@Chaosus Chaosus merged commit 3326cb0 into godotengine:master Feb 28, 2021
@Chaosus Chaosus deleted the fix_graphedit_zoom_connection branch February 28, 2021 05:21
@akien-mga akien-mga added the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Feb 28, 2021
@akien-mga
Copy link
Member

I tried to cherry-pick for 3.2.4 but aside from usual style conflicts, it seems there might be a previous change to GraphEdit which was not cherry-picked and is used here (connecting_valid), so this might be worth backporting with a dedicated PR (maybe including that other previous commit if it's also safe for 3.2).

@YuriSizov YuriSizov mentioned this pull request Mar 1, 2021
Closed
@akien-mga akien-mga mentioned this pull request Mar 19, 2021
Merged
@AaronRecord AaronRecord mentioned this pull request Mar 19, 2021
Merged
BuzzBurrowes added a commit to BuzzBurrowes/godot that referenced this pull request Mar 23, 2021
@BuzzBurrowes
cherry picked godotengine#46441
a18b293
BuzzBurrowes added a commit to BuzzBurrowes/godot that referenced this pull request Mar 23, 2021
@BuzzBurrowes
cherry picked godotengine#46441 again
5248bab
@Chaosus Chaosus mentioned this pull request Mar 23, 2021
Closed
@akien-mga
Copy link
Member

Will be cherry-picked via #47173.

@akien-mga akien-mga removed the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Apr 26, 2021
@vincepr vincepr mentioned this pull request May 3, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KoBeWi KoBeWi KoBeWi approved these changes

Assignees
No one assigned
Labels
bug topic:gui
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.

Can't grab outputs from visual shader node's when the visual shader editor is zoomed out a little
3 participants
@Chaosus @akien-mga @KoBeWi