Release v232 for mainnet #1386

atodorov · 2023-10-30T19:15:14Z

Description of proposed changes

Practical tips for PR review & merge:

All GitHub Actions report PASS
Newly added code/functions have unit tests
- Coverage tools report all newly added lines as covered
- The positive scenario is exercised
- Negative scenarios are exercised, e.g. assert on all possible errors
- Assert on events triggered if applicable
- Assert on changes made to storage if applicable
Modified behavior/functions - try to make sure above test items are covered
Integration tests are added if applicable/needed

b/c this commit has been applied to `main` directly without making it into `dev` and `testnet` branches and that causes conflicts with the next release. In case creditcoin-js type definitions need updating the CI job running inside the pull request will take care of it. This reverts commit 68a1240.

b/c this commit has been applied to `main` directly without making it into `dev` and `testnet` branches and that causes conflicts with the next release. In case creditcoin-js type definitions need updating the CI job running inside the pull request will take care of it. This reverts commit 29c8355.

both Creditcoin integration tests and cc-cli integration tests are building creditcoin-node with exactly the same arguments. Merging the two definitions allows both jobs to depend on a common build job which should reduce overall CI turnaround time.

so that descriptions will appear properly

- brings parity with testnet releases - makes it more obvious what release it is

in preparation for request_collect_coins_v2

- fix initial WeightInfo to be greater than zero before benchmarks have the chance to update this appropriately

from -> sender to -> recipient maintain old names for serialization/deserialization b/c tests are consuming raw JSON data when mocking Ethereum responses

- both ETH wallets are controlled by the same Creditcoin account - mixing 2nd ETH address with tx hash from the 1st address should fail verify_collect_coins() in OCW.

- more descriptive names - assert on WeightInfo - return WeightInfo > 0 to pass CI before benchmarks have the chance to update the weights with correct values

Bumps [paste](https://github.com/dtolnay/paste) from 1.0.12 to 1.0.14. - [Release notes](https://github.com/dtolnay/paste/releases) - [Commits](dtolnay/paste@1.0.12...1.0.14) --- updated-dependencies: - dependency-name: paste dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>

Bumps [strum](https://github.com/Peternator7/strum) from 0.24.1 to 0.25.0. - [Changelog](https://github.com/Peternator7/strum/blob/master/CHANGELOG.md) - [Commits](https://github.com/Peternator7/strum/commits) --- updated-dependencies: - dependency-name: strum dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>

…as well

…tAddress->GATEFaucetAc… (#1333) * renamed TokenContract->BurnDetail and GATEFaucetAddress->GATEFaucetAccount * updated benchmarking.rs * Auto-update creditcoin-js type definitions --------- Co-authored-by: Zachary Frederick <zach.frederick@gluwa.com> Co-authored-by: gluwa-bot <creditcoin@gluwa.com>

this should have been removed as part of #1289

github-actions · 2023-10-31T11:22:40Z

For full LLVM coverage report click here!

codecov-commenter · 2023-10-31T13:36:49Z

Codecov Report

Merging #1386 (3851575) into main (15ae61d) will decrease coverage by 58.24%.
The diff coverage is 34.72%.

@@             Coverage Diff             @@
##             main    #1386       +/-   ##
===========================================
- Coverage   71.11%   12.87%   -58.24%     
===========================================
  Files         106       31       -75     
  Lines       12470      955    -11515     
  Branches      114      120        +6     
===========================================
- Hits         8868      123     -8745     
+ Misses       3593      832     -2761     
+ Partials        9        0        -9

Files	Coverage Δ
scripts/cc-cli/src/api.ts	`33.33% <0.00%> (-66.67%)`	⬇️
scripts/cc-cli/src/utils/tx.ts	`27.65% <0.00%> (-23.41%)`	⬇️
scripts/cc-cli/src/utils/tests.ts	`0.00% <0.00%> (ø)`
...ripts/cc-cli/src/test/integration-tests/helpers.ts	`0.00% <0.00%> (-79.63%)`	⬇️
scripts/cc-cli/src/commands/collectCoins.ts	`41.93% <41.93%> (ø)`
scripts/cc-cli/src/commands/registerAddress.ts	`36.36% <36.36%> (ø)`

... and 82 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

b/c the self-hosted GitHub runners have an extra 60GB of space there!

b/c try-runtime is greedy

atodorov changed the base branch from dev to main October 30, 2023 19:16

atodorov added 2 commits October 30, 2023 21:21

atodorov mentioned this pull request Oct 30, 2023

[CSUB-845] Split cleanup of expired entries across multiple blocks #1353

Merged

9 tasks

gluwa-bot and others added 26 commits October 31, 2023 12:06

Auto-update creditcoin-js type definitions

2b8f0a3

Merge cli-ci.yml and ci.yml

d396596

both Creditcoin integration tests and cc-cli integration tests are building creditcoin-node with exactly the same arguments. Merging the two definitions allows both jobs to depend on a common build job which should reduce overall CI turnaround time.

Add format string for parametrized test

6ff923b

so that descriptions will appear properly

Auto-update pallet weights

46b6fb3

Mainnet releases would be named with the -mainnet suffix

23a9cc6

- brings parity with testnet releases - makes it more obvious what release it is

Introduce the set_gate_contract() extrinsic

ea8ecc1

in preparation for request_collect_coins_v2

Update test names and add more assertions

11de944

- fix initial WeightInfo to be greater than zero before benchmarks have the chance to update this appropriately

Auto-update creditcoin-js type definitions

6a3d7d6

Rename variable for better readability

0ff1237

Rename struct fields for more readability

2c23f01

from -> sender to -> recipient maintain old names for serialization/deserialization b/c tests are consuming raw JSON data when mocking Ethereum responses

Add integration test for collect-coins and 2 ETH wallets

97f4be1

- both ETH wallets are controlled by the same Creditcoin account - mixing 2nd ETH address with tx hash from the 1st address should fail verify_collect_coins() in OCW.

Add integration test for set_gate_contract()

1fa9d27

Auto-update creditcoin-js type definitions

aea3279

Fix typo is storage type name

61addc9

Auto-update creditcoin-js type definitions

8f81187

added set_gate_faucet extrinsic

4940cef

Ammend tests for set_gate_faucet()

a828f70

- more descriptive names - assert on WeightInfo - return WeightInfo > 0 to pass CI before benchmarks have the chance to update the weights with correct values

Add integration test for set_gate_faucet()

a15ea55

Auto-update creditcoin-js type definitions

6710ca4

Rename GATEFaucetAddress -> GATEFaucetAccount

2dbe1f0

Rename test function to match

c29a956

Auto-update creditcoin-js type definitions

b623673

Auto-update creditcoin-js type definitions

3d613e0

Auto-update creditcoin-js type definitions

3887b16

atodorov and others added 10 commits October 31, 2023 12:08

Add more tests for request_collect_coins_v2

d70cb42

Execute request_collect_coins() tests for request_collect_coins_v2() …

2554313

…as well

Add more documentation for zombienet/

4e2aae5

Bicep uses double slash, not hash

1a9fc4c

Auto-update pallet weights

155d03b

Remove cp of a non existent file in CI

fcbab4f

this should have been removed as part of #1289

Auto-update pallet weights

c35d7ae

Bump runtime version

90f9a98

Auto-update creditcoin-js type definitions

79ccfe9

atodorov force-pushed the release/v232-for-mainnet branch from 5d1572b to 79ccfe9 Compare October 31, 2023 10:09

atodorov requested review from nathanwhit, pLabarta, zacharyfrederick and AdaJane October 31, 2023 10:10

Remove redundant imports

2788a9e

zacharyfrederick approved these changes Oct 31, 2023

View reviewed changes

atodorov force-pushed the release/v232-for-mainnet branch from b35f6de to 64a3eb5 Compare October 31, 2023 13:44

Testing: specify --base-path /mnt

0cc4bd7

b/c the self-hosted GitHub runners have an extra 60GB of space there!

atodorov force-pushed the release/v232-for-mainnet branch from 64a3eb5 to 0cc4bd7 Compare October 31, 2023 14:06

atodorov and others added 3 commits October 31, 2023 18:42

Increase rpc-max-{request|response}-size during testing

3438120

b/c try-runtime is greedy

Only test runtime migrations from pallet creditcoin

da7d27a

Fix case on --pallet flag in CI test

3851575

AdaJane approved these changes Oct 31, 2023

View reviewed changes

AdaJane marked this pull request as ready for review October 31, 2023 23:13

AdaJane merged commit 4b055b3 into main Oct 31, 2023
37 of 40 checks passed

AdaJane deleted the release/v232-for-mainnet branch October 31, 2023 23:14

atodorov mentioned this pull request Nov 1, 2023

Fix try-runtime migration test #1389

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Release v232 for mainnet #1386

Release v232 for mainnet #1386

atodorov commented Oct 30, 2023

github-actions bot commented Oct 31, 2023

codecov-commenter commented Oct 31, 2023 •

edited

Loading

Release v232 for mainnet #1386

Release v232 for mainnet #1386

Conversation

atodorov commented Oct 30, 2023

Description of proposed changes

github-actions bot commented Oct 31, 2023

codecov-commenter commented Oct 31, 2023 • edited Loading

Codecov Report

codecov-commenter commented Oct 31, 2023 •

edited

Loading