-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CSUB-699: Remove switch_to_pos() extrinsic b/c mainnet has now been migrated to PoS #1289
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #1289 +/- ##
==========================================
+ Coverage 8.32% 70.69% +62.36%
==========================================
Files 28 103 +75
Lines 889 12082 +11193
Branches 114 114
==========================================
+ Hits 74 8541 +8467
- Misses 815 3532 +2717
- Partials 0 9 +9
... and 80 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good. Should we communicate this removal to the community? Seems prudent from a transparency perspective
Edit: Maybe a better question for marketing
For full LLVM coverage report click here! |
22c071f
to
169c8e7
Compare
- keep storage item b/c it is important - remove related tests and test jobs
e1ea7d9
to
2f00f69
Compare
4ab7500
to
5895f70
Compare
5895f70
to
dd527d8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, later on I would consider options for removing the whole pallet while migrating SwitchBlockNumber somewhere else
this should have been removed as part of #1289
this should have been removed as part of #1289
this should have been removed as part of #1289
this should have been removed as part of #1289
this should have been removed as part of #1289
this should have been removed as part of #1289
this should have been removed as part of #1289
Description of proposed changes
Practical tips for PR review & merge: