Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSUB-699: Remove switch_to_pos() extrinsic b/c mainnet has now been migrated to PoS #1289

Merged
merged 5 commits into from
Sep 12, 2023

Conversation

atodorov
Copy link
Contributor

  • keep storage item b/c it is important
  • remove related tests and test jobs

Description of proposed changes


Practical tips for PR review & merge:

  • All GitHub Actions report PASS
  • Newly added code/functions have unit tests
    • Coverage tools report all newly added lines as covered
    • The positive scenario is exercised
    • Negative scenarios are exercised, e.g. assert on all possible errors
    • Assert on events triggered if applicable
    • Assert on changes made to storage if applicable
  • Modified behavior/functions - try to make sure above test items are covered
  • Integration tests are added if applicable/needed

@codecov-commenter
Copy link

codecov-commenter commented Aug 30, 2023

Codecov Report

Merging #1289 (885322b) into dev (38ee975) will increase coverage by 62.36%.
Report is 11 commits behind head on dev.
The diff coverage is n/a.

❗ Current head 885322b differs from pull request most recent head c93d72f. Consider uploading reports for the commit c93d72f to get more accurate results

@@            Coverage Diff             @@
##             dev    #1289       +/-   ##
==========================================
+ Coverage   8.32%   70.69%   +62.36%     
==========================================
  Files         28      103       +75     
  Lines        889    12082    +11193     
  Branches     114      114               
==========================================
+ Hits          74     8541     +8467     
- Misses       815     3532     +2717     
- Partials       0        9        +9     
Files Changed Coverage Δ
pallets/pos-switch/src/lib.rs 71.42% <ø> (ø)
runtime/src/lib.rs 17.34% <ø> (ø)
runtime/src/version.rs 0.00% <ø> (ø)

... and 80 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@zacharyfrederick zacharyfrederick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good. Should we communicate this removal to the community? Seems prudent from a transparency perspective

Edit: Maybe a better question for marketing

@github-actions
Copy link

For full LLVM coverage report click here!

@atodorov atodorov force-pushed the testing/CSUB-699-remove_switch_to_pos branch from 22c071f to 169c8e7 Compare August 31, 2023 10:24
@atodorov atodorov marked this pull request as ready for review August 31, 2023 10:24
pLabarta
pLabarta previously approved these changes Aug 31, 2023
- keep storage item b/c it is important
- remove related tests and test jobs
@atodorov atodorov force-pushed the testing/CSUB-699-remove_switch_to_pos branch from e1ea7d9 to 2f00f69 Compare September 5, 2023 09:30
@atodorov atodorov force-pushed the testing/CSUB-699-remove_switch_to_pos branch from 4ab7500 to 5895f70 Compare September 5, 2023 14:57
@atodorov atodorov force-pushed the testing/CSUB-699-remove_switch_to_pos branch from 5895f70 to dd527d8 Compare September 5, 2023 15:44
@atodorov atodorov requested review from AdaJane and pLabarta September 6, 2023 08:18
Copy link
Contributor

@pLabarta pLabarta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, later on I would consider options for removing the whole pallet while migrating SwitchBlockNumber somewhere else

@atodorov atodorov merged commit 7ae99bc into dev Sep 12, 2023
@atodorov atodorov deleted the testing/CSUB-699-remove_switch_to_pos branch September 12, 2023 08:30
atodorov added a commit that referenced this pull request Sep 20, 2023
this should have been removed as part of
#1289
atodorov added a commit that referenced this pull request Sep 20, 2023
this should have been removed as part of
#1289
nathanwhit pushed a commit that referenced this pull request Sep 20, 2023
this should have been removed as part of
#1289
atodorov added a commit that referenced this pull request Sep 21, 2023
this should have been removed as part of
#1289
atodorov added a commit that referenced this pull request Sep 21, 2023
this should have been removed as part of
#1289
atodorov added a commit that referenced this pull request Oct 31, 2023
this should have been removed as part of
#1289
AdaJane pushed a commit that referenced this pull request Oct 31, 2023
this should have been removed as part of
#1289
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants