Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSUB-518: follow up - renamed TokenContract->BurnDetail and GATEFaucetAddress->GATEFaucetAc… #1333

Merged
merged 3 commits into from
Sep 19, 2023

Conversation

zacharyfrederick
Copy link
Contributor

No description provided.

@zacharyfrederick zacharyfrederick marked this pull request as ready for review September 19, 2023 21:09
nathanwhit
nathanwhit previously approved these changes Sep 19, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #1333 (07b4461) into dev (1c85989) will decrease coverage by 0.96%.
The diff coverage is 85.00%.

@@            Coverage Diff             @@
##              dev    #1333      +/-   ##
==========================================
- Coverage   71.16%   70.20%   -0.96%     
==========================================
  Files         107      107              
  Lines       12494    12491       -3     
  Branches      120      120              
==========================================
- Hits         8891     8769     -122     
- Misses       3593     3722     +129     
+ Partials       10        0      -10     
Files Changed Coverage Δ
pallets/creditcoin/src/types.rs 83.07% <ø> (ø)
pallets/creditcoin/src/types/collect_coins.rs 85.91% <0.00%> (ø)
pallets/creditcoin/src/lib.rs 83.19% <66.66%> (-0.05%) ⬇️
pallets/creditcoin/src/ocw/tasks/collect_coins.rs 99.18% <100.00%> (-0.01%) ⬇️
pallets/creditcoin/src/tests.rs 98.24% <100.00%> (ø)

... and 7 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link

For full LLVM coverage report click here!

@nathanwhit nathanwhit merged commit 1567089 into dev Sep 19, 2023
@nathanwhit nathanwhit deleted the csub-518-naming-changes branch September 19, 2023 22:33
nathanwhit pushed a commit that referenced this pull request Sep 19, 2023
…tAddress->GATEFaucetAc… (#1333)

* renamed TokenContract->BurnDetail and GATEFaucetAddress->GATEFaucetAccount

* updated benchmarking.rs

* Auto-update creditcoin-js type definitions

---------

Co-authored-by: Zachary Frederick <zach.frederick@gluwa.com>
Co-authored-by: gluwa-bot <creditcoin@gluwa.com>
nathanwhit pushed a commit that referenced this pull request Sep 20, 2023
…tAddress->GATEFaucetAc… (#1333)

* renamed TokenContract->BurnDetail and GATEFaucetAddress->GATEFaucetAccount

* updated benchmarking.rs

* Auto-update creditcoin-js type definitions

---------

Co-authored-by: Zachary Frederick <zach.frederick@gluwa.com>
Co-authored-by: gluwa-bot <creditcoin@gluwa.com>
atodorov pushed a commit that referenced this pull request Oct 31, 2023
…tAddress->GATEFaucetAc… (#1333)

* renamed TokenContract->BurnDetail and GATEFaucetAddress->GATEFaucetAccount

* updated benchmarking.rs

* Auto-update creditcoin-js type definitions

---------

Co-authored-by: Zachary Frederick <zach.frederick@gluwa.com>
Co-authored-by: gluwa-bot <creditcoin@gluwa.com>
AdaJane pushed a commit that referenced this pull request Oct 31, 2023
…tAddress->GATEFaucetAc… (#1333)

* renamed TokenContract->BurnDetail and GATEFaucetAddress->GATEFaucetAccount

* updated benchmarking.rs

* Auto-update creditcoin-js type definitions

---------

Co-authored-by: Zachary Frederick <zach.frederick@gluwa.com>
Co-authored-by: gluwa-bot <creditcoin@gluwa.com>
nathanwhit pushed a commit that referenced this pull request Jan 3, 2024
…tAddress->GATEFaucetAc… (#1333)

* renamed TokenContract->BurnDetail and GATEFaucetAddress->GATEFaucetAccount

* updated benchmarking.rs

* Auto-update creditcoin-js type definitions

---------

Co-authored-by: Zachary Frederick <zach.frederick@gluwa.com>
Co-authored-by: gluwa-bot <creditcoin@gluwa.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants