Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[0.4] Transition and binding fixes #389

Merged
merged 3 commits into from
Nov 29, 2019
Merged

[0.4] Transition and binding fixes #389

merged 3 commits into from
Nov 29, 2019

Conversation

kvark
Copy link
Member

@kvark kvark commented Nov 28, 2019

Back-ports #387 as well as a tiny bit of #378 to v0.4 branch and bumps the patch version.
Fixes #384

Copy link
Collaborator

@grovesNL grovesNL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
bors r+

bors bot added a commit that referenced this pull request Nov 29, 2019
389: [0.4] Transition and binding fixes r=grovesNL a=kvark

Back-ports #387 as well as a tiny bit of #378 to v0.4 branch and bumps the patch version.
Fixes  #384

Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
@bors
Copy link
Contributor

bors bot commented Nov 29, 2019

Build succeeded

@bors bors bot merged commit 27d88fa into gfx-rs:v0.4 Nov 29, 2019
@kvark kvark deleted the track branch November 29, 2019 03:58
@cloudhead
Copy link
Contributor

Could we get a new version of wgpu-rs too?

@kvark
Copy link
Member Author

kvark commented Nov 30, 2019 via email

@cloudhead
Copy link
Contributor

Ah indeed, good to know, thanks!

kvark pushed a commit to kvark/wgpu that referenced this pull request Jun 3, 2021
389: build master docs r=grovesNL,kvark a=dakom

builds docs and deploys to `doc/` folder on gh_pages branch

doesn't interfere with other gh_pages contents.

assumes `ACCESS_TOKEN` is set as a github secret (if it isn't, please see https://help.github.com/en/github/authenticating-to-github/creating-a-personal-access-token-for-the-command-line)

see live example on my fork: https://dakom.github.io/wgpu-rs/doc/wgpu/index.html

* closes gfx-rs#379



Co-authored-by: David Komer <david.komer@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants