Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unlock the crate types #379

Closed
kvark opened this issue Nov 15, 2019 · 1 comment · Fixed by #381
Closed

Unlock the crate types #379

kvark opened this issue Nov 15, 2019 · 1 comment · Fixed by #381
Assignees
@kvark
Labels
external: upstream Issues happening in lower level APIs or platforms type: bug Something isn't working
Milestone
Gecko integration

Comments

@kvark
Copy link
Member

kvark commented Nov 15, 2019

The way "wgpu" is moved to Gecko involves removing the "crate-type" records from the Cargo manifests, because otherwise we get these linking errors:

We need to re-enable the crate types in order to produce proper binaries separately from Gecko.
This is blocked on rust-lang/cargo#4280
@kvark kvark added type: bug Something isn't working external: upstream Issues happening in lower level APIs or platforms labels Nov 15, 2019
@kvark kvark added this to the Gecko integration milestone Nov 15, 2019
@kvark
Copy link
Member Author

kvark commented Nov 15, 2019

@grovesNL you've been working on a separate wgpu-types crate, right? I wonder if we'd hit a collision if I start implementing the solution to this issue. Which is, based on the discussion with @jrmuizel, moving the core Rust API into a separate crate that both wgpu-native and wgpu-remote would depend on.

@kvark kvark self-assigned this Nov 15, 2019
@kvark kvark mentioned this issue Nov 15, 2019
Merged
bors bot added a commit that referenced this issue Nov 15, 2019
@bors @kvark
Merge #380
f221a65 
380: More licenses for Gecko r=kvark a=kvark

These are all the last things we need to match Gecko, with an exception of #379 

Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
@kvark kvark mentioned this issue Nov 16, 2019
Merged
@bors bors bot closed this as completed in #381 Nov 16, 2019
@bors bors bot closed this as completed in aa14f7f Nov 16, 2019
kvark pushed a commit to kvark/wgpu that referenced this issue Jun 3, 2021
@dakom
[rs] build master docs
ffd2ffb 
Deploys to gh_pages branch in `doc/` folder

* closes gfx-rs#379
kvark pushed a commit to kvark/wgpu that referenced this issue Jun 3, 2021
@bors @dakom
[rs] Merge gfx-rs#389
6947184 
389: build master docs r=grovesNL,kvark a=dakom

builds docs and deploys to `doc/` folder on gh_pages branch

doesn't interfere with other gh_pages contents.

assumes `ACCESS_TOKEN` is set as a github secret (if it isn't, please see https://help.github.com/en/github/authenticating-to-github/creating-a-personal-access-token-for-the-command-line)

see live example on my fork: https://dakom.github.io/wgpu-rs/doc/wgpu/index.html

* closes gfx-rs#379



Co-authored-by: David Komer <david.komer@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kvark kvark

Labels
external: upstream Issues happening in lower level APIs or platforms type: bug Something isn't working
Projects
None yet
Milestone
Gecko integration
Development

Successfully merging a pull request may close this issue.

Separate Native from the Core kvark/wgpu
1 participant
@kvark