Support for merged depth-stencil states #378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grovesNL
approved these changes
Nov 8, 2019
|
@grovesNL this is largely rewritten/extended and should be ready now. Please have a look when you get a chance. |
grovesNL
reviewed
Nov 19, 2019
grovesNL
approved these changes
Nov 19, 2019
|
Bors r=grovesNL
… On Nov 19, 2019, at 05:54, Josh Groves ***@***.***> wrote:
@grovesNL approved this pull request.
In wgpu-core/src/track/texture.rs:
> continue;
}
+ debug_assert_eq!(aspects, mip_aspects);
Alright this makes sense, thanks!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
Build succeeded |
This was referenced Nov 28, 2019
kvark
pushed a commit
to kvark/wgpu
that referenced
this pull request
Jun 3, 2021
380: Documentation Pass r=kvark a=cwfitzgerald The wgpu-rs component of gfx-rs#728. Closes gfx-rs#378. Notable changes not mentioned in wgpu PR: - Reexported the wgt-local types whenever we have a type definition. These are reexported as `ThingBase`. This is unfortunately the only way to actually get their documentation to show up, aliases have no way of "inheriting" the documentation. - Added wgpu logo to docs! - Hid vertex_format_size macro. Co-authored-by: Connor Fitzgerald <connorwadefitzgerald@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #376
@Yatekii would you be able to test it and confirm the fix?