Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(source-map-debugger): Mention potential dist mismatch in 'not found' case #57658

Merged
merged 2 commits into from
Oct 6, 2023
Merged

feat(source-map-debugger): Mention potential dist mismatch in 'not found' case #57658

merged 2 commits into from
Oct 6, 2023

Conversation

lforst
Copy link
Member

@lforst lforst commented Oct 6, 2023 •
edited
Loading

Since we have database restrictions in the backend we can still have a dist mismatch even though not-found is returned instead of dist.

We need to adjust the text in the modal to still show a hint about a potential dist mismatch, even when we hit the not-found case.

Fixes #57553

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Oct 6, 2023
@lforst lforst requested review from mydea and Lms24 October 6, 2023 12:36
@lforst lforst merged commit ba2fb6f into master Oct 6, 2023
@lforst lforst deleted the lforst-include-dist-wording-in-source-map-debugger branch October 6, 2023 13:52
@github-actions github-actions bot locked and limited conversation to collaborators Oct 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Lms24 Lms24 Lms24 approved these changes

@mydea mydea Awaiting requested review from mydea

Assignees
No one assigned
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add dist and protocol wild mask to RN Source Maps Guide
2 participants
@lforst @Lms24