Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(source-map-debugger): Mention potential dist mismatch in 'not found' case #57658

Merged
merged 2 commits into from
Oct 6, 2023
Merged

feat(source-map-debugger): Mention potential dist mismatch in 'not found' case #57658

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8c39852
feat(source-map-debugger): Mention potential dist mismatch in 'not fo…
lforst Oct 6, 2023
e2aaab7
.
lforst Oct 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions static/app/components/events/interfaces/sourceMapsDebuggerModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -840,6 +840,19 @@ function ReleaseSourceFileMatchingChecklistItem({
</li>
))}
</InstructionList>
<p>
{/* wrong-dist is not deterministically returned in the case of wrong dist values because of database restrictions */}
{sourceResolutionResults.dist !== null
? tct(
'This event has a dist value [dist]. Please check that you uploaded your artifacts with dist [dist].',
{
dist: <MonoBlock>{sourceResolutionResults.dist}</MonoBlock>,
}
)
: t(
"This event doesn't have a dist value. Please check that you uploaded your artifacts without dist value."
)}
</p>
{/* TODO: Link to uploaded files for this release. */}
<p>
{tct(
Expand Down Expand Up @@ -946,6 +959,19 @@ function ReleaseSourceMapMatchingChecklistItem({
}
)}
</p>
<p>
{/* wrong-dist is not deterministically returned in the case of wrong dist values because of database restrictions */}
{sourceResolutionResults.dist !== null
? tct(
'This event has a dist value [dist]. Please check that you uploaded your sourcemaps with dist [dist].',
{
dist: <MonoBlock>{sourceResolutionResults.dist}</MonoBlock>,
}
)
: t(
"This event doesn't have a dist value. Please check that you uploaded your sourcemaps without dist value."
)}
</p>
{/* TODO: Link to Uploaded Artifacts */}
</CheckListInstruction>
<SourceMapStepNotRequiredNote />
Expand Down