Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dist and protocol wild mask to RN Source Maps Guide #57553

Open
Tracked by #55662
krystofwoldrich opened this issue Oct 5, 2023 · 5 comments · Fixed by #57658
Open
Tracked by #55662

Add dist and protocol wild mask to RN Source Maps Guide #57553

krystofwoldrich opened this issue Oct 5, 2023 · 5 comments · Fixed by #57658
Assignees

Comments

@krystofwoldrich
Copy link
Member

The new source maps guide works flawlessly for RN with Debug IDs.

But the Releases information is missing information about dist and doesn't respect the protocol wild card ~/.

These match:
app:///index.js
~/index.js

https://sentry-sdks.sentry.io/issues/4045737360/events/67db3c663e4044969dd17cc0ff3433c8/

Example DebugIDs:
Screenshot 2023-10-05 at 14 43 56

Example Releases:
Screenshot 2023-10-05 at 14 42 26

@krystofwoldrich
Copy link
Member Author

Reopening this as the protocol wild mask is not fixed yet.

@lforst
Copy link
Member

lforst commented Nov 23, 2023

@krystofwoldrich What do you mean exactly?

@krystofwoldrich
Copy link
Member Author

@lforst The Release tab shows app:///index.js and ~/index.js as not matching. But the ~ si a wild mask for any protocol. so app:// is ~ and then /index.js matches.

@lforst
Copy link
Member

lforst commented Nov 23, 2023

Just to be clear, the text is correct is correct here. It's the lookup logic that is faulty.

@krystofwoldrich
Copy link
Member Author

@lforst

Just to be clear, the text is correct is correct here. It's the lookup logic that is faulty.

Yes, I read it wrong. 😅 Yes the text is correct.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants