-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wizard only onboarding #55844
Wizard only onboarding #55844
Conversation
Remix, SvelteKit, and Nextjs Someone can validate if these changes, by someone I mean a real developer :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code itself looks good 👍
Co-authored-by: ArthurKnaus <arthur.knaus@sentry.io>
Co-authored-by: ArthurKnaus <arthur.knaus@sentry.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only requesting changes so we don't merge this until getsentry/sentry-wizard#433 is resolved. Let's only publish this once the wizard is fully ready.
existing remix wizard until remix source maps changes with cli and token are done
@Lms24 good to go? cc @ArthurKnaus |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, good call on proceeding here w/o remix
@smeubank fixed the linter errors, should be good now 🤞 |
Remix, SvelteKit, and NextjsSomeone can validate if these changes, by someone I mean a real developer :D
SvelteKit: local

NextJs: local

Remix: localcloses #55777
EDIT: Remix is still open, waiting on getsentry/sentry-wizard#433, merging this without remix. Remix change is tracked in #54615