Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wizard only onboarding #55844

Merged
merged 6 commits into from
Sep 8, 2023
Merged

Wizard only onboarding #55844

merged 6 commits into from
Sep 8, 2023

Conversation

smeubank
Copy link
Member

@smeubank smeubank commented Sep 7, 2023

Remix, SvelteKit, and Nextjs

Someone can validate if these changes, by someone I mean a real developer :D

SvelteKit: local
image

NextJs: local
image

Remix: local
image

closes #55777

EDIT: Remix is still open, waiting on getsentry/sentry-wizard#433, merging this without remix. Remix change is tracked in #54615

Remix, SvelteKit, and Nextjs

Someone can validate if these changes, by someone I mean a real developer :D
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Sep 7, 2023
Copy link
Member

@ArthurKnaus ArthurKnaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code itself looks good 👍

smeubank and others added 2 commits September 7, 2023 16:05
Co-authored-by: ArthurKnaus <arthur.knaus@sentry.io>
Co-authored-by: ArthurKnaus <arthur.knaus@sentry.io>
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only requesting changes so we don't merge this until getsentry/sentry-wizard#433 is resolved. Let's only publish this once the wizard is fully ready.

existing remix wizard until remix source maps changes with cli and token are done
@smeubank
Copy link
Member Author

smeubank commented Sep 8, 2023

Only requesting changes so we don't merge this until getsentry/sentry-wizard#433 is resolved. Let's only publish this once the wizard is fully ready.

@Lms24 good to go?

cc @ArthurKnaus

Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good call on proceeding here w/o remix

@smeubank smeubank enabled auto-merge (squash) September 8, 2023 10:46
@Lms24
Copy link
Member

Lms24 commented Sep 8, 2023

@smeubank fixed the linter errors, should be good now 🤞

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove manual setup snippets from Next, Remix and Sveltekit getting started pages
3 participants