Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remix wizard should pass org, project and url to upload-sourcemaps script #433

Closed
3 tasks done
Lms24 opened this issue Sep 8, 2023 · 0 comments · Fixed by #434
Closed
3 tasks done

Remix wizard should pass org, project and url to upload-sourcemaps script #433

Lms24 opened this issue Sep 8, 2023 · 0 comments · Fixed by #434
Assignees
@onurtemizkan

Comments

@Lms24
Copy link
Member

Lms24 commented Sep 8, 2023 •
edited
Loading

Once getsentry/sentry-javascript#8984 is done, we should adjust the Remix wizard to pass the safe parameters to upload-sourcemaps.

  • always pass org and project
  • if self-hosted, also pass url
  • Remove optional org and project parameters from addSentryCliConfig to avoid this in the future

    sentry-wizard/src/utils/clack-utils.ts

    Lines 283 to 289 in 6f4ad3b

    export async function addSentryCliConfig(
    authToken: string,
    setupConfig: CliSetupConfig = sourceMapsCliSetupConfig,
    orgSlug?: string,
    projectSlug?: string,
    ): Promise<void> {
    const configExists = fs.existsSync(
This was referenced Sep 8, 2023
Merged
Merged
@onurtemizkan onurtemizkan mentioned this issue Sep 8, 2023
Merged
smeubank added a commit to getsentry/sentry that referenced this issue Sep 8, 2023
@smeubank @ArthurKnaus
Wizard only onboarding (#55844)
c7cc307 
~Remix~, SvelteKit, and Nextjs

Someone can validate if these changes, by someone I mean a real
developer :D

SvelteKit: local
<img width="1204" alt="image"
src="https://github.com/getsentry/sentry/assets/47563310/6f6f8abb-b439-4f64-ab38-328fa8ed25f4">

NextJs: local
<img width="1203" alt="image"
src="https://github.com/getsentry/sentry/assets/47563310/ccd6f39c-cd0b-447e-be6d-f71803019735">

~Remix: local~
<img width="1216" alt="image"
src="https://github.com/getsentry/sentry/assets/47563310/379815d1-cbdc-49ae-9e39-d8efc40e9211">


closes #55777

EDIT: Remix is still open, waiting on
getsentry/sentry-wizard#433, merging this
without remix. Remix change is tracked in #54615

---------

Co-authored-by: ArthurKnaus <arthur.knaus@sentry.io>
Lms24 pushed a commit that referenced this issue Sep 13, 2023
@onurtemizkan
feat(remix): Pass org, project, url to upload-sourcemaps scri…
4ec63a1 
…pt. (#434)

see #433
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@onurtemizkan onurtemizkan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(remix): Pass org, project, url to upload-sourcemaps script. getsentry/sentry-wizard
2 participants
@onurtemizkan @Lms24