Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remix upload-sourcemaps script should take org, project and url arguments #8984

Closed
Lms24 opened this issue Sep 8, 2023 · 0 comments · Fixed by #8985
Closed

Remix upload-sourcemaps script should take org, project and url arguments #8984

Lms24 opened this issue Sep 8, 2023 · 0 comments · Fixed by #8985
Assignees

Comments

@Lms24
Copy link
Member

Lms24 commented Sep 8, 2023

Problem Statement

Currently, the upload-sourcemaps doesn’t take arguments for org, project and url. source maps upload is configured by writing all these values into .sentryclirc alongside the auth token. Because of the auth token, .sentryclirc shouldn't be commited to the users' repos.

The consequence is that users not only have to add the auth token as an env variable in their CI setup but also env variables for project, org (and URL if self-hosted). Also local development is more complicated this way.

Solution Brainstorm

It's safe to commit org, project and (if self-hosted) url to repos. So let's adjust the script to take these parameters as arguments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants