ref(vsts): Shadow deprecate VSTS plugin #29202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leeandher
commented
Oct 8, 2021
Comment on lines
+28
to
+29
| if not features.has("organizations:integrations-ignore-vsts-deprecation", organization): | ||
| queryset = queryset.exclude(provider="visualstudio") |
There was a problem hiding this comment.
This code took two seconds to write and like two hours for me to figure out how to test and setup since VSTS itself is deprecated on Microsoft's end. I guess this isn't a review comment and more just a public record of my troubles.
size-limit report
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See API-2136
This PR, just like the one for teamwork and clubhouse removes and hides VSTS from the frontend and API to simulate deleting the plugin's source code. Similar to clubhouse, this plugin is already hidden for users who don't have it installed, so that isn't imaged here.
With the feature flag:
Without the feature flag