Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(teamwork): Shadow deprecate teamwork plugin #29052

Merged
merged 8 commits into from
Oct 6, 2021
Merged

Conversation

leeandher
Copy link
Member

@leeandher leeandher commented Oct 4, 2021

This PR shadow deprecates the teamwork plugin, preventing those without the organization feature from viewing, updating or using the plugin. The feature is organizations:integrations-ignore-teamwork-deprecation and will be removed after the full deprecation has been done.

With the feature enabled:

  • Issue linking is still visible:

image

  • still available in the plugin list
  • still displayed when installed on the sidebar
  • still available in the integration directory (regardless of installation)
visible.in.plugin.integration.pages.mov
  • still available with a direct link to the plugin (settings/:orgId/plugins/teamwork/)

image


Without the feature enabled

  • Issue linking disappears

image

  • None of the plugin pages show teamwork
  • Individual view throws a 404 (we don't handle it well so it errors, but that is out of scope of this ticket)
not.on.plugin.pages.mov
  • No longer on the integration directory (regardless of whether or not it is installed)
Not.in.integration.directory.mov
  • Direct link throws 404 (we don't handle it well so it errors, but that is out of scope of this ticket)
direct.link.returns.404.mov

@leeandher leeandher requested a review from a team October 4, 2021 19:59
@mgaeta mgaeta assigned leeandher and unassigned mgaeta Oct 5, 2021
@leeandher leeandher merged commit 71166f9 into master Oct 6, 2021
@leeandher leeandher deleted the leander/API-2135 branch October 6, 2021 17:12
@github-actions github-actions bot locked and limited conversation to collaborators Oct 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants