Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(clubhouse): Shadow deprecate clubhouse plugin #29082

Merged
merged 3 commits into from
Oct 7, 2021

Conversation

leeandher
Copy link
Member

@leeandher leeandher commented Oct 5, 2021

See: API-2137

This PR adds the clubhouse plugin to the map of shadow deprecated plugins. It prevents access to the plugin from the plugin directory and integration directory. This plugin is already hidden by default for those who don't have it installed already, but now even they won't see it listed.

With feature-flag enabled:

  • External issue annotations are still visible

image

image

  • Linked stories appear in the sidebar

image

  • New stories can be created/linked in the sidebar

image

  • Clubhouse appears in the integration + plugin directory (if installed)

image

image

image


Without feature-flag enabled:

  • External issue annotations are gone

image

image

  • Clubhouse stories are gone (and can no longer be created/linked)

image

  • Clubhouse is missing from the integration + plugin directory (regardless of installation)

image

image

image

@leeandher leeandher changed the base branch from master to leander/API-2135 October 5, 2021 19:10
@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2021

size-limit report

Path Base Size (767bf79) Current Size Change
src/sentry/static/sentry/dist/entrypoints/app.js 52.67 KB 52.67 KB -0.01% 🔽
src/sentry/static/sentry/dist/entrypoints/sentry.css 70.9 KB 70.9 KB 0%

Base automatically changed from leander/API-2135 to master October 6, 2021 17:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants