Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(py3): Stop tagging the -py3 images #22470

Merged
merged 1 commit into from
Dec 4, 2020
Merged

build(py3): Stop tagging the -py3 images #22470

merged 1 commit into from
Dec 4, 2020

Conversation

BYK
Copy link
Member

@BYK BYK commented Dec 4, 2020

This is the final step in making the PY3 version the default for Docker images and self-hosted. It is part 5/5:

  1. Add -py2 variants for the Python 2 build tags and introduce the SENTRY_PYTHON2 env variable usage (ci(py3): Make py2 builds available under -py2 suffix #22460)
  2. Switch getsentry/onpremise to Python 3 by default*, introducing the SENTRY_PYTHON2 env var for Py2 builds via the -py2 suffix (ref(py3): Make PY3 the default*, add SENTRY_PYTHON self-hosted#763)
  3. Move the unsuffixed version of the builds to Python 3 (build(py3): Make PY3 images default (w/o suffix) #22466)
  4. Remove the SENTRY_PYTHON3 env var support and -py3 prefix usage from getsentry/onpremise (ref(py3): Remove SENTRY_PYTHON3 and -py3 versons self-hosted#764)
  5. Remove tagging of -py3 builds from getsentry/sentry

This is the final step in making the PY3 version the default for Docker images and self-hosted. It is part **5/5**:

1. ~~Add `-py2` variants for the Python 2 build tags and introduce the `SENTRY_PYTHON2` env variable usage~~ (#22460)
2. ~~Switch getsentry/onpremise to Python 3 by default*, introducing the `SENTRY_PYTHON2` env var for Py2 builds via the `-py2` suffix~~ (getsentry/self-hosted#763)
3. ~~Move the unsuffixed version of the builds to Python 3~~ (#22466)
4. ~~Remove the `SENTRY_PYTHON3` env var support and `-py3` prefix usage from getsentry/onpremise~~ (getsentry/self-hosted#764)
5. **Remove tagging of `-py3` builds from getsentry/sentry**
Copy link
Member

@chadwhitacre chadwhitacre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍻

@BYK BYK merged commit 51ac134 into master Dec 4, 2020
@BYK BYK deleted the byk/build/bye--py3 branch December 4, 2020 22:46
BYK added a commit that referenced this pull request Dec 15, 2020
BYK added a commit that referenced this pull request Dec 15, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Dec 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants