Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref(py3): Make PY3 the default*, add SENTRY_PYTHON #763

Merged
merged 7 commits into from
Dec 4, 2020
Merged

ref(py3): Make PY3 the default*, add SENTRY_PYTHON #763

merged 7 commits into from
Dec 4, 2020

Conversation

BYK
Copy link
Member

@BYK BYK commented Dec 4, 2020 •
edited
Loading

This is in preparation to make the PY3 version the default* for Docker images and self-hosted. It is part 2/5:

  1. Add -py2 variants for the Python 2 build tags and introduce the SENTRY_PYTHON2 env variable usage (ci(py3): Make py2 builds available under -py2 suffix sentry#22460)
  2. Switch getsentry/onpremise to Python 3 by default*, introducing the SENTRY_PYTHON2 env var for Py2 builds via the -py2 suffix
  3. Move the unsuffixed version of the builds to Python 3
  4. Remove the SENTRY_PYTHON3 env var support and -py3 prefix usage from getsentry/onpremise
  5. Remove tagging of -py3 builds from here

* this will only happen when item 3 above gets landed

@BYK
ref(py3): Make PY3 the default, add SENTRY_PYTHON2
45ef378 
This is in preparation to make the PY3 version the default for Docker images and self-hosted. It is part **2/5**:

1. Add `-py2` variants for the Python 2 bulid tags and introduce the `SENTRY_PYTHON2` env variable usage
2. **Switch getsentry/onpremise to Python 3 by default, introducing the `SENTRY_PYTHON2` env var for Py2 builds via the `-py2` suffix**
3. Move the unsuffixed version of the builds to Python 3
4. Remove the `SENTRY_PYTHON3` env var support and `-py3` prefix usage from getsentry/onpremise
5. Remove tagging of `-py3` builds from here

Depends on getsentry/sentry#22460.
@BYK BYK requested review from chadwhitacre and a team December 4, 2020 18:39
@BYK BYK changed the title ref(py3): Make PY3 the default, add SENTRY_PYTHON2 ref(py3): Make PY3 the default, add SENTRY_PYTHON Dec 4, 2020
@BYK BYK marked this pull request as draft December 4, 2020 18:52
@BYK BYK changed the title ref(py3): Make PY3 the default, add SENTRY_PYTHON ref(py3): Make PY3 the default*, add SENTRY_PYTHON Dec 4, 2020
@BYK BYK changed the title ref(py3): Make PY3 the default*, add SENTRY_PYTHON ref(py3): Make PY3 the default, add SENTRY_PYTHON Dec 4, 2020
@BYK BYK changed the title ref(py3): Make PY3 the default, add SENTRY_PYTHON ref(py3): Make PY3 the default*, add SENTRY_PYTHON Dec 4, 2020
@BYK BYK marked this pull request as ready for review December 4, 2020 19:36
@BYK BYK merged commit 06fb0d7 into master Dec 4, 2020
@BYK BYK deleted the byk/ref/default-to-py3 branch December 4, 2020 19:43
@BYK BYK mentioned this pull request Dec 4, 2020
Merged
BYK added a commit to getsentry/sentry that referenced this pull request Dec 4, 2020
@BYK
build(py3): Make PY3 images default (w/o suffix)
f178245 
This is in preparation to make the PY3 version the default for Docker images and self-hosted. It is part **3/5**:

1. ~~Add `-py2` variants for the Python 2 build tags and introduce the `SENTRY_PYTHON2` env variable usage~~ (#22460)
2. ~~Switch getsentry/onpremise to Python 3 by default*, introducing the `SENTRY_PYTHON2` env var for Py2 builds via the `-py2` suffix~~ (getsentry/self-hosted#763)
3. **Move the unsuffixed version of the builds to Python 3**
4. Remove the `SENTRY_PYTHON3` env var support and `-py3` prefix usage from getsentry/onpremise
5. Remove tagging of `-py3` builds from here

We should still have the `-py3` images, whcih will be the same with the images w/o the suffix.
BYK added a commit to getsentry/sentry that referenced this pull request Dec 4, 2020
@BYK
build(py3): Make PY3 images default (w/o suffix) (#22466)
9936343 
This is in preparation to make the PY3 version the default for Docker images and self-hosted. It is part **3/5**:

1. ~~Add `-py2` variants for the Python 2 build tags and introduce the `SENTRY_PYTHON2` env variable usage~~ (#22460)
2. ~~Switch getsentry/onpremise to Python 3 by default*, introducing the `SENTRY_PYTHON2` env var for Py2 builds via the `-py2` suffix~~ (getsentry/self-hosted#763)
3. **Move the unsuffixed version of the builds to Python 3**
4. Remove the `SENTRY_PYTHON3` env var support and `-py3` prefix usage from getsentry/onpremise
5. Remove tagging of `-py3` builds from here

We should still have the `-py3` images, whcih will be the same with the images w/o the suffix.
@BYK BYK mentioned this pull request Dec 4, 2020
Merged
BYK added a commit that referenced this pull request Dec 4, 2020
@BYK
ref(py3): Remove SENTRY_PYTHON3 and -py3 versons
419b63a 
This is in preparation to make the PY3 version the default for Docker images and self-hosted. It is part **4/5**:

1. ~~Add `-py2` variants for the Python 2 build tags and introduce the `SENTRY_PYTHON2` env variable usage~~ (getsentry/sentry#22460)
2. ~~Switch getsentry/onpremise to Python 3 by default*, introducing the `SENTRY_PYTHON2` env var for Py2 builds via the `-py2` suffix~~ (#763)
3. ~~Move the unsuffixed version of the builds to Python 3~~ (getsentry/sentry#22466)
4. **Remove the `SENTRY_PYTHON3` env var support and `-py3` prefix usage from getsentry/onpremise**
5. Remove tagging of `-py3` builds from getsentry/sentry
BYK added a commit to getsentry/sentry that referenced this pull request Dec 4, 2020
@BYK
build(py3): Stop tagging the -py3 images
ed68165 
This is the final step in making the PY3 version the default for Docker images and self-hosted. It is part **5/5**:

1. ~~Add `-py2` variants for the Python 2 build tags and introduce the `SENTRY_PYTHON2` env variable usage~~ (#22460)
2. ~~Switch getsentry/onpremise to Python 3 by default*, introducing the `SENTRY_PYTHON2` env var for Py2 builds via the `-py2` suffix~~ (getsentry/self-hosted#763)
3. ~~Move the unsuffixed version of the builds to Python 3~~ (#22466)
4. ~~Remove the `SENTRY_PYTHON3` env var support and `-py3` prefix usage from getsentry/onpremise~~ (getsentry/self-hosted#764)
5. **Remove tagging of `-py3` builds from getsentry/sentry**
@BYK BYK mentioned this pull request Dec 4, 2020
Merged
BYK added a commit that referenced this pull request Dec 4, 2020
@BYK
ref(py3): Remove SENTRY_PYTHON3 and -py3 versons (#764)
f885ece 
This is in preparation to make the PY3 version the default for Docker images and self-hosted. It is part **4/5**:

1. ~~Add `-py2` variants for the Python 2 build tags and introduce the `SENTRY_PYTHON2` env variable usage~~ (getsentry/sentry#22460)
2. ~~Switch getsentry/onpremise to Python 3 by default*, introducing the `SENTRY_PYTHON2` env var for Py2 builds via the `-py2` suffix~~ (#763)
3. ~~Move the unsuffixed version of the builds to Python 3~~ (getsentry/sentry#22466)
4. **Remove the `SENTRY_PYTHON3` env var support and `-py3` prefix usage from getsentry/onpremise**
5. Remove tagging of `-py3` builds from getsentry/sentry
BYK added a commit to getsentry/sentry that referenced this pull request Dec 4, 2020
@BYK
build(py3): Stop tagging the -py3 images (#22470)
51ac134 
This is the final step in making the PY3 version the default for Docker images and self-hosted. It is part **5/5**:

1. ~~Add `-py2` variants for the Python 2 build tags and introduce the `SENTRY_PYTHON2` env variable usage~~ (#22460)
2. ~~Switch getsentry/onpremise to Python 3 by default*, introducing the `SENTRY_PYTHON2` env var for Py2 builds via the `-py2` suffix~~ (getsentry/self-hosted#763)
3. ~~Move the unsuffixed version of the builds to Python 3~~ (#22466)
4. ~~Remove the `SENTRY_PYTHON3` env var support and `-py3` prefix usage from getsentry/onpremise~~ (getsentry/self-hosted#764)
5. **Remove tagging of `-py3` builds from getsentry/sentry**
@github-actions github-actions bot locked and limited conversation to collaborators Dec 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chadwhitacre chadwhitacre chadwhitacre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Self-hosted Sentry
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BYK @chadwhitacre