Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(py3): Remove SENTRY_PYTHON3 and -py3 versons #764

Merged
merged 4 commits into from
Dec 4, 2020
Merged

Conversation

BYK
Copy link
Member

@BYK BYK commented Dec 4, 2020

This is in preparation to make the PY3 version the default for Docker images and self-hosted. It is part 4/5:

  1. Add -py2 variants for the Python 2 build tags and introduce the SENTRY_PYTHON2 env variable usage (ci(py3): Make py2 builds available under -py2 suffix sentry#22460)
  2. Switch getsentry/onpremise to Python 3 by default*, introducing the SENTRY_PYTHON2 env var for Py2 builds via the -py2 suffix (ref(py3): Make PY3 the default*, add SENTRY_PYTHON #763)
  3. Move the unsuffixed version of the builds to Python 3 (build(py3): Make PY3 images default (w/o suffix) sentry#22466)
  4. Remove the SENTRY_PYTHON3 env var support and -py3 prefix usage from getsentry/onpremise
  5. Remove tagging of -py3 builds from getsentry/sentry

This is in preparation to make the PY3 version the default for Docker images and self-hosted. It is part **4/5**:

1. ~~Add `-py2` variants for the Python 2 build tags and introduce the `SENTRY_PYTHON2` env variable usage~~ (getsentry/sentry#22460)
2. ~~Switch getsentry/onpremise to Python 3 by default*, introducing the `SENTRY_PYTHON2` env var for Py2 builds via the `-py2` suffix~~ (#763)
3. ~~Move the unsuffixed version of the builds to Python 3~~ (getsentry/sentry#22466)
4. **Remove the `SENTRY_PYTHON3` env var support and `-py3` prefix usage from getsentry/onpremise**
5. Remove tagging of `-py3` builds from getsentry/sentry
@BYK BYK requested review from chadwhitacre and a team December 4, 2020 21:25
Copy link
Member

@chadwhitacre chadwhitacre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$ gb
  byk/ref/bye--py3
* master
$ ag py3
install.sh
220:docker pull ${SENTRY_IMAGE}${SENTRY_PYTHON2:+-py2}${SENTRY_PYTHON3:+-py3} || true;

sentry/Dockerfile
4:FROM ${SENTRY_IMAGE}${SENTRY_PYTHON2:+-py2}${SENTRY_PYTHON3:+-py3}
$ ag PYTHON3
install.sh
220:docker pull ${SENTRY_IMAGE}${SENTRY_PYTHON2:+-py2}${SENTRY_PYTHON3:+-py3} || true;

docker-compose.yml
11:      - SENTRY_PYTHON3

sentry/Dockerfile
3:ARG SENTRY_PYTHON3
4:FROM ${SENTRY_IMAGE}${SENTRY_PYTHON2:+-py2}${SENTRY_PYTHON3:+-py3}
$     
$ 
$ 
$ co byk/ref/bye--py3  
Switched to branch 'byk/ref/bye--py3'
Your branch is up to date with 'origin/byk/ref/bye--py3'.
$ ag py3
$ ag PYTHON3
$

BYK added a commit to getsentry/sentry that referenced this pull request Dec 4, 2020
This is the final step in making the PY3 version the default for Docker images and self-hosted. It is part **5/5**:

1. ~~Add `-py2` variants for the Python 2 build tags and introduce the `SENTRY_PYTHON2` env variable usage~~ (#22460)
2. ~~Switch getsentry/onpremise to Python 3 by default*, introducing the `SENTRY_PYTHON2` env var for Py2 builds via the `-py2` suffix~~ (getsentry/self-hosted#763)
3. ~~Move the unsuffixed version of the builds to Python 3~~ (#22466)
4. ~~Remove the `SENTRY_PYTHON3` env var support and `-py3` prefix usage from getsentry/onpremise~~ (getsentry/self-hosted#764)
5. **Remove tagging of `-py3` builds from getsentry/sentry**
@BYK BYK merged commit f885ece into master Dec 4, 2020
@BYK BYK deleted the byk/ref/bye--py3 branch December 4, 2020 22:46
BYK added a commit to getsentry/sentry that referenced this pull request Dec 4, 2020
This is the final step in making the PY3 version the default for Docker images and self-hosted. It is part **5/5**:

1. ~~Add `-py2` variants for the Python 2 build tags and introduce the `SENTRY_PYTHON2` env variable usage~~ (#22460)
2. ~~Switch getsentry/onpremise to Python 3 by default*, introducing the `SENTRY_PYTHON2` env var for Py2 builds via the `-py2` suffix~~ (getsentry/self-hosted#763)
3. ~~Move the unsuffixed version of the builds to Python 3~~ (#22466)
4. ~~Remove the `SENTRY_PYTHON3` env var support and `-py3` prefix usage from getsentry/onpremise~~ (getsentry/self-hosted#764)
5. **Remove tagging of `-py3` builds from getsentry/sentry**
@github-actions github-actions bot locked and limited conversation to collaborators Dec 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants