fix: Ensure install wizard passes in common scenarios #12778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
billyvg
approved these changes
Apr 15, 2019
| if ( | ||
| option.value !== undefined && | ||
| option.value !== undefined && option.value !== "" && option.value !== null && |
There was a problem hiding this comment.
So false and 0 are the only valid falsey values?
There was a problem hiding this comment.
Yeah I'm not sure - Im not a big fan of the way this works (the install wizard options, forms used here), but its very hard to come up with a "correct" approach that could be achieved in an afternoon.
There was a problem hiding this comment.
Specifically this behavior happened with mail.username and mail.password - those will no longer force the install wizard to prompt, it was just something I caught in parallel.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patches around a few issues with how options are inferred in the frontend to trigger the setup wizard.
We likely need to do more work to make this correct, but this will at least solve the current state of the world.