Skip to content
This repository has been archived by the owner on Aug 30, 2023. It is now read-only.

9.1: install fails due to mail.use-tls setting #163

Closed
acdha opened this issue Apr 5, 2019 · 10 comments
Closed

9.1: install fails due to mail.use-tls setting #163

acdha opened this issue Apr 5, 2019 · 10 comments
Assignees

Comments

@acdha
Copy link

acdha commented Apr 5, 2019

I spun up a fresh install of a custom onbuild deployment of 9.1 and it's failing with this exception:

AssertionError: u'mail.use-tls' cannot be changed at runtime because it is configured on disk

Changing the value of SENTRY_EMAIL_USE_TLS does not appear to have an effect. This is almost the verbatim onbuild module except that it adds a wrapper which populates the environment from AWS SSM values (working around FarGate design limitations).

@ei-grad
Copy link

ei-grad commented Apr 6, 2019

The similar issue, but with 'mail.from' field. The docker sentry installation procedure is broken.

@mattrobenolt
Copy link
Contributor

Thanks for bringing his up. I’m going to look into this.

@ei-grad
Copy link

ei-grad commented Apr 6, 2019

Checked the same process for 9.0 - all working as expected.

@acdha
Copy link
Author

acdha commented Apr 6, 2019 via email

@mafredri
Copy link

I had the mail.from issue as well. I can only reproduce the issue when creating a superuser account, and upon login Sentry asks to define base url / mail (from) and some other settings. It's not possible to get past this due to the mail.from being configured on disk.

Removing the following lines solved the issue:

email = env('SENTRY_EMAIL_HOST') or (env('SMTP_PORT_25_TCP_ADDR') and 'smtp')
if email:
SENTRY_OPTIONS['mail.backend'] = 'smtp'
SENTRY_OPTIONS['mail.host'] = email
SENTRY_OPTIONS['mail.password'] = env('SENTRY_EMAIL_PASSWORD') or ''
SENTRY_OPTIONS['mail.username'] = env('SENTRY_EMAIL_USER') or ''
SENTRY_OPTIONS['mail.port'] = int(env('SENTRY_EMAIL_PORT') or 25)
SENTRY_OPTIONS['mail.use-tls'] = env('SENTRY_EMAIL_USE_TLS', False)
else:

SENTRY_OPTIONS['mail.from'] = env('SENTRY_SERVER_EMAIL') or 'root@localhost'

Not sure if all of it was necessary. It's possible only line 270 needed to be removed.

@dcramer dcramer self-assigned this Apr 14, 2019
@dcramer
Copy link
Member

dcramer commented Apr 14, 2019

I wonder why we're binding default values in docker vs forcing you to configure it via the UI when it's not setup from the environment.. seems backwards from any other way we'd suggest to install it.

@dcramer
Copy link
Member

dcramer commented Apr 19, 2019

Will be fixed in 9.1.1 which we're hoping to get out later today.

@dcramer dcramer closed this as completed Apr 19, 2019
dcramer added a commit to getsentry/sentry that referenced this issue Apr 19, 2019
@rbtellis
Copy link

rbtellis commented Apr 22, 2019

Can this fix be uploaded to Dockerhub please? I am trying to use the onpremise docker scripts, but this bug is preventing me from installing. I attempted to build the new docker image, but got a gpg failure.
gpg: Can't check signature: No public key

Thanks!

@dcramer
Copy link
Member

dcramer commented Apr 22, 2019

We do not control the speed at which Docker publishes new version:

docker-library/official-images#5772

@rbtellis
Copy link

Ok, thanks for the info!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants