feat: Improve configuration to be less Docker-specific #167
Conversation
|
I haven't actually tested this out yet, just wanted to get this up before I get my day started. |
| SENTRY_OPTIONS['mail.port'] = int(env('SENTRY_EMAIL_PORT') or 25) | ||
| SENTRY_OPTIONS['mail.use-tls'] = env('SENTRY_EMAIL_USE_TLS', False) | ||
| else: | ||
| SENTRY_OPTIONS['mail.backend'] = 'dummy' |
There was a problem hiding this comment.
ive intentionally removed this behavior as email is required for a production sentry install, and you can configure the smtp settings in the UI
|
Also still not 100% clear if I should PR this or just patch the 9.1 config in docker-sentry, but I assumed this was the source of truth. |
|
Hi, |
|
@markotitel thanks! Might have to make the value checks look for empty before coercing. |
This removes auto-binding of various values (specified in config.yaml) when they're not actually configured. It ensures that these values can then be configured from the web UI as Sentry has intended.
038f968 to
41200b7
Compare
|
@markotitel feel free to give the branch another try now |
|
Maybe forgot |
|
@gebv should be in there -- make sure you do a hard reset as ive forced pushed any fixes |
| SENTRY_OPTIONS['slack.client-id'] = env('SLACK_CLIENT_ID') | ||
| SENTRY_OPTIONS['slack.client-secret'] = env('SLACK_CLIENT_SECRET') | ||
| SENTRY_OPTIONS['slack.verification-token'] = env('SLACK_VERIFICATION_TOKEN') or '' | ||
| def bind_env_config(config=SENTRY_OPTIONS, mapping=ENV_CONFIG_MAPPING): |
There was a problem hiding this comment.
Do you need to worry about mutable default arguments here?
There was a problem hiding this comment.
Nevermind, it isn't a relevant issue for this function.
|
Expanded config to include new github + vsts vars. |
sentry.conf.py
Outdated
| 'SENTRY_EMAIL_PASSWORD': 'mail.password', | ||
| 'SENTRY_EMAIL_USER': 'mail.username', | ||
| 'SENTRY_EMAIL_PORT': ('mail.port', int), | ||
| 'SENTRY_EMAIL_USE_TLS': ('mail.use-tls', bool), |
There was a problem hiding this comment.
We need to use sentry.utils.types:Bool otherwise this coersion is going to yield a very unexpected behavior and a change from what it was before. Doing env('...', False) with False as the default would cause it to use this Bool type becuase it gets passed through sentry.utils.types:type_from_value.
This removes auto-binding of various values (specified in config.yaml) when they're not actually configured. It ensures that these values can then be configured from the web UI as Sentry has intended.
See also getsentry/docker-sentry#163 (comment)