Skip to content

Commit

Permalink
fix: Dont trigger upgrade on non-required fields which are empty
Browse files Browse the repository at this point in the history
  • Loading branch information
dcramer committed Apr 19, 2019
1 parent 48ae1db commit 99a6bdd
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions src/sentry/templatetags/sentry_react.py
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,9 @@ def _needs_upgrade():

# Check all required options to see if they've been set
for key in options.filter(flag=options.FLAG_REQUIRED):
# ignore required flags which can be empty
if key.flags & options.FLAG_ALLOW_EMPTY:
continue
# Ignore mail.* keys if smtp is disabled
if smtp_disabled and key.name[:5] == 'mail.':
continue
Expand Down

0 comments on commit 99a6bdd

Please sign in to comment.