Hide problem alerts after successful new dataset/property requests #967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthew-white
approved these changes
Apr 14, 2024
| "newPropertyName": "New property name" | ||
| "newPropertyName": "New property name", | ||
| "problem": { | ||
| "409_3": "A property already exists in this Entity List with the name of “{propertyName}”." |
There was a problem hiding this comment.
I usually just use quotes for strings that might contain a space. Since propertyName will be a single word, what do you think about removing the quotes around {propertyName}? No strong feelings!
There was a problem hiding this comment.
I think the quotes isolate the name better than without them, since there is no other formatting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes getodk/central#624 and closes getodk/central#626
Also add custom error message for property name conflict similar to message for dataset name conflict in PR #966 for issue getodk/central#625. Doing so closes getodk/central#634.
What has been done to verify that this works as intended?
Why is this the best possible solution? Were any other approaches considered?
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
Does this change require updates to user documentation? If so, please file an issue here and include the link below.
Before submitting this PR, please make sure you have:
npm run testandnpm run lintand confirmed all checks still pass OR confirm CircleCI build passes