Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

While creating a dataset manually via "+New” button, at the end of the error informing that the dataset already exists there is "56” added #625

Closed
dbemke opened this issue Apr 8, 2024 · 5 comments · Fixed by getodk/central-frontend#966
Assignees
Labels
behavior verified Behavior has been manually verified entities Multiple Encounter workflows frontend Requires a change to the UI

Comments

@dbemke
Copy link

dbemke commented Apr 8, 2024

Problem description

While creating a dataset manually via "+New” button, at the end of the error informing that the dataset already exists there is "56” added.

URL of the page

https://staging.getodk.cloud/

Steps to reproduce the problem

  1. Navigate to Entities Lists page.
  2. Click "+New” button.
  3. Enter a dataset name that already exists in the project.
  4. Click "Create”.

Screenshot

56inError

Expected behavior

"56" shouldn't be in the error message.

Central version shown in version.txt

https://staging.getodk.cloud/
versions:
f0b2a90 (v2023.5.1-5-gf0b2a90)
+2bb17a501416814bbd987ddc953abc5b0c40c58a client (v2023.5.0-43-g2bb17a50)
+267e0ad7806057fc82894f58bea680627f1de5cd server (v2023.5.0-49-g267e0ad7)

Browser version

Chrome and Firefox

@lognaturel
Copy link
Member

This is a side effect of error messages being pretty raw! Entity list names are unique within a project. The error message is saying that there is already an entity list with name trees in project with id 56. I agree that it looks strange. It happens across other resources as well and we could consider those together at a later time.

@matthew-white
Copy link
Member

matthew-white commented Apr 8, 2024

It happens across other resources as well

Now that we've resolved #144, I think we've mostly addressed this for other resources. We tend to handle 409 errors on a case-by-case basis rather than in a global way. For example:

I think we could fix this one now or in a future release. We have an existing mechanism to handle Problem responses like this, so it shouldn't be a heavy lift.

@lognaturel
Copy link
Member

Oh! Yes, of course, sorry about the misinformation.

@github-project-automation github-project-automation bot moved this to 🕒 backlog in ODK Central Apr 9, 2024
@matthew-white matthew-white added frontend Requires a change to the UI needs testing Needs manual testing entities Multiple Encounter workflows labels Apr 9, 2024
@ktuite ktuite moved this from 🕒 backlog to ✏️ in progress in ODK Central Apr 12, 2024
@github-project-automation github-project-automation bot moved this from ✏️ in progress to ✅ done in ODK Central Apr 12, 2024
@srujner
Copy link

srujner commented Apr 15, 2024

Tested with Success

1 similar comment
@dbemke
Copy link
Author

dbemke commented Apr 15, 2024

Tested with Success

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
behavior verified Behavior has been manually verified entities Multiple Encounter workflows frontend Requires a change to the UI
Projects
Status: ✅ done
Development

Successfully merging a pull request may close this issue.

5 participants