Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oidc/login: add integration test #1399

Merged
merged 2 commits into from
Feb 12, 2025

Conversation

alxndrsn
Copy link
Contributor

@alxndrsn alxndrsn commented Feb 11, 2025

Preliminary work for #1230

What has been done to verify that this works as intended?

There's a test.

Why is this the best possible solution? Were any other approaches considered?

None,

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

It should not, it's just a test.

Does this change require updates to the API documentation? If so, please update docs/api.yaml as part of this PR.

No.

Before submitting this PR, please make sure you have:

  • run make test and confirmed all checks still pass OR confirm CircleCI build passes
  • verified that any code from external sources are properly credited in comments or that everything is internally sourced

@alxndrsn alxndrsn changed the title /oidc/login: add integration test oidc/login: add integration test Feb 11, 2025
@alxndrsn alxndrsn marked this pull request as ready for review February 11, 2025 13:51
@alxndrsn alxndrsn mentioned this pull request Feb 11, 2025
2 tasks
@alxndrsn alxndrsn requested a review from ktuite February 11, 2025 13:54
@alxndrsn alxndrsn merged commit 1544035 into getodk:master Feb 12, 2025
6 checks passed
@alxndrsn alxndrsn deleted the oidc-integration-tests-2 branch February 12, 2025 05:26
alxndrsn pushed a commit to alxndrsn/odk-central-backend that referenced this pull request Feb 12, 2025
These were incorrectly excluded while merging getodk#1392 & getodk#1399 into master.
alxndrsn added a commit that referenced this pull request Feb 18, 2025
These were incorrectly excluded while merging #1392 & #1399 into master.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants