Update openid-client to v6 #1394
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v6 is a complete rewrite, with API changes: https://github.com/panva/openid-client/releases/tag/v6.0.0 Closes getodk#1230
alxndrsn
commented
Feb 10, 2025
alxndrsn
commented
Feb 10, 2025
alxndrsn
commented
Feb 10, 2025
alxndrsn
commented
Feb 10, 2025
alxndrsn
commented
Feb 10, 2025
alxndrsn
commented
Feb 10, 2025
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
added 2 commits
February 11, 2025 13:56
alxndrsn
commented
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
openid-clientv6 is a complete rewrite, with API changes: https://github.com/panva/openid-client/releases/tag/v6.0.0API reference: https://github.com/panva/openid-client/blob/v6.1.7/docs/README.md
Closes #1230
What has been done to verify that this works as intended?
Existing tests; new tests at #1392
Why is this the best possible solution? Were any other approaches considered?
Staying up-to-date with security-focussed libraries seems like a sensible approach. An alternative might be to fork the
openid-clientlibrary, but this seems like high-risk, unnecessary work for no obvious benefit.How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
It should not affect users.
Does this change require updates to the API documentation? If so, please update docs/api.yaml as part of this PR.
No.
Before submitting this PR, please make sure you have:
make testand confirmed all checks still pass OR confirm CircleCI build passes